Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix chords with chained groups (#5947) #5984

Merged
merged 1 commit into from Mar 2, 2020

Conversation

the-owl
Copy link
Contributor

@the-owl the-owl commented Mar 1, 2020

Description

Fixes #5947

Copy link
Member

@auvipy auvipy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can't you add unit test for this?

@auvipy auvipy added this to the 4.4.x milestone Mar 1, 2020
@the-owl
Copy link
Contributor Author

the-owl commented Mar 1, 2020

Yes, I'll update this PR with a test soon.

@codecov
Copy link

codecov bot commented Mar 1, 2020

Codecov Report

Merging #5984 into master will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5984      +/-   ##
==========================================
- Coverage   83.43%   83.42%   -0.01%     
==========================================
  Files         145      145              
  Lines       17177    17179       +2     
  Branches     2115     2116       +1     
==========================================
  Hits        14332    14332              
- Misses       2626     2627       +1     
- Partials      219      220       +1
Impacted Files Coverage Δ
celery/canvas.py 92.68% <0%> (-0.26%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6892beb...dbf7ee8. Read the comment docs.

@auvipy auvipy merged commit 01dd66c into celery:master Mar 2, 2020
This was referenced Sep 18, 2020
@auvipy
Copy link
Member

auvipy commented Oct 13, 2020

would be great if you check the two related open PR #6342 & #6354

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

chord of chains with groups: body duplication and invalid task execution order
3 participants