Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed the paragraph about using librabbitmq as optimization practice. Refer to #5872 #5873

Merged
merged 1 commit into from Dec 13, 2019
Merged

Removed the paragraph about using librabbitmq as optimization practice. Refer to #5872 #5873

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
16 changes: 0 additions & 16 deletions docs/userguide/optimizing.rst
View file
Open in desktop
Expand Up @@ -48,22 +48,6 @@ like adding new worker nodes, or revoking unnecessary tasks.
General Settings
================

.. _optimizing-librabbitmq:

librabbitmq
-----------

If you're using RabbitMQ (AMQP) as the broker then you can install the
:pypi:`librabbitmq` module to use an optimized client written in C:

.. code-block:: console

$ pip install librabbitmq

The 'amqp' transport will automatically use the librabbitmq module if it's
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This part still seems to be true, see kombu's code: https://github.com/celery/kombu/blob/81101877a09e8f4442555c6c74b4836f113e4f51/kombu/connection.py#L251-L252

#4693 says that librabbitmq is no longer the recommended package, but the code in kombu hasn't be updated to stop automatically converting the amqp:// prefix to librabbitmq:// if it is installed.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we need to update kombu as well

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've made a PR on kombu to address this.

installed, or you can also specify the transport you want directly by using
the ``pyamqp://`` or ``librabbitmq://`` prefixes.

.. _optimizing-connection-pools:

Broker Connection Pools
Expand Down