Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add auto expiry for DynamoDB backend #5805
Add auto expiry for DynamoDB backend #5805
Changes from 12 commits
c703215
ddf1f7c
5a61b13
31c1bfd
b5bf089
455d55b
9d041e9
224aefd
832bc5b
b499e5a
e3dcfa2
a46ed1a
b0c56a8
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
elif -> if ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure about this one. I've left it as an if, elif, else now (added the else just now), which I think makes sense. Let me know if I should re-do it, though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm no authority but
elif
usually makes me look at the previous condition. It satisfies the negation of previous condition and the following condition. I don't think its needed here (or anywhere where you have short-circuitingif ... return/raise)
)IMO
if
is less interleaved thanelif
and easier to read.But its fine either way, just wanted you to consider it.