fix: Ensure group tasks are deeply deserialised

Fixes #6341
celery · Sep 16, 2020 · b8e20c7 · b8e20c7
1 parent 3ef2d12
commit b8e20c7
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/celery/canvas.py b/celery/canvas.py
@@ -1028,8 +1028,9 @@ class group(Signature):
 
     @classmethod
     def from_dict(cls, d, app=None):
+        tasks = [maybe_signature(task) for task in d["kwargs"]["tasks"]]
         return _upgrade(
-            d, group(d['kwargs']['tasks'], app=app, **d['options']),
+            d, group(tasks, app=app, **d['options']),
         )
 
     def __init__(self, *tasks, **options):

diff --git a/t/unit/tasks/test_canvas.py b/t/unit/tasks/test_canvas.py
@@ -633,7 +633,6 @@ def test_from_dict(self):
         x['args'] = None
         assert group.from_dict(dict(x))
 
-    @pytest.mark.xfail(reason="#6341")
     def test_from_dict_deep_deserialize(self):
         subtask = self.add.s(1, 2)
         original_group = group([subtask] * 42)