Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gem updates required to run app #120

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ewalk153
Copy link

@ewalk153 ewalk153 commented Mar 7, 2022

  • Mimemagic version in Gemfile.lock was revoke due to license changes
  • Puma version failed to compile
  • Minitest and listen had build failures

Ran bundle update mimemagic minitest listen puma to generate this change.

`bundle update mimemagic minitest listen puma`
@eoinkelly
Copy link

I had to change this to bundle update mimemagic minitest listen puma nokogiri (adding nokogiri).

@santiagorodriguez96
Copy link
Contributor

Are you still having issues to build the app? I noticed the build was failing in Travis CI because of mimemagic and I solved it by updating Rails to v6.0.6 – see #122. Now the build seems to be working properly 🙂

@heliocola
Copy link
Contributor

Hi @santiagorodriguez96 : there is another PR with upgrade to Ruby 3.1.4 as 2.7.7 is quite old and past EOL (https://endoflife.date/ruby).

Any chance you can spend some time to upgrade?
I am setting it up on my machine as I will talk about it at Ruby Conf Taiwan next month! :-D

@heliocola
Copy link
Contributor

👋 @ewalk153 : thank you for sending this PR!

Did you have a chance to check out the latest changes in the master branch?
Several gems, ruby, rails all have been updated.

@santiagorodriguez96 : I think the issues on this one are taken care in the other PRs, specially in the Rails 7 upgrade! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants