Fix tests failing with OpenSSL 3 #24
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The issue is that we set up the certificate to have an invalid version (version is `3` initially) but the certificate is later signed which, in newer versions of OpenSSL, updates the version to a valid one (version changes to be `2`). This PR fixes the issue by changing the `version` _after_ the certificate has been signed.
Those jobs were failing for newer OpenSSL versions. Now that we have fixed the specs for those, we can bring them back.
santiagorodriguez96
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Some tests were failing in the CI when using
macosbecause it comes with ruby installed with OpenSSL v3.2.0. The issue is that, for testing theconformant?method, we set up a certificate to have an invalid version (version is3initially) and expect the certificate to not be conformant. But when setting up the certificate we have to sign it which, in newer versions of OpenSSL, updates the version to a valid one (version changes to be2), thus causing the expectation to not be met and therefore the spec to fail.This PR fixes the issue by changing the
versionafter the certificate has been signed.