Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update date format in French locale file #1840

Merged
merged 5 commits into from
May 14, 2024

Conversation

andrewleith
Copy link
Member

@andrewleith andrewleith commented May 13, 2024

Summary | Résumé

This PR fixes a bug in the scheduler where the year 2020 was hardcoded into the date format of the date preview.

Related cards

Before

image

After

image

Test instructions | Instructions pour tester la modification

Schedule a send

  • Login to your service
  • Choose a template
  • Click Yes, add recipients
  • Select Many recipients, click Continue
  • Click Choose a file
  • Upload a csv file (you only need one address)
  • Switch the UI to French
  • Click Programmer l'envoi (near the bottom of the page)
  • Choose a date in the calendar
    • Ensure the preview date in the yellow box says 2024 (and not 2020!)

Étapes consécutives (1., 2., 3., …) qui décrivent la façon de tester la
modification. Elles aideront les développeurs à faire des tests sans avoir à
jouer au détective. Veuillez aussi inclure toutes les étapes de configuration
de l’environnement qui ne font pas partie des étapes normales dans le fichier
README et tout élément temporel requis.

The date format in the French locale file was updated to use the "dddd D MMMM YYYY" format instead of "dddd D MMMM 2020". This change ensures that the date format includes the current year dynamically.
Copy link

@andrewleith andrewleith merged commit 3ca6537 into main May 14, 2024
9 checks passed
@andrewleith andrewleith deleted the fix/scheduler-dates-fr branch May 14, 2024 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants