Reinstate bulk sms limit #1834
Merged
Reinstate bulk sms limit #1834
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…)" This reverts commit 1eec27f.
- Bumped boto3 so we have compatibility with latest utils - Added a check to utils.py to ensure we only return validation errors for SMS bulk sends, not email
This was referenced May 3, 2024
🧪 Review environmenthttps://xp2fvbvxbtukzzopjat6xk2daa0vjcty.lambda-url.ca-central-1.on.aws/ |
jzbahrai
approved these changes
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary | Résumé
This PR reinstates bulk sms validation code that was reverted in this PR due to issues with the added validation firing on bulk emails as well.
Related Issues | Cartes liées
cds-snc/notification-utils#294
cds-snc/notification-api#2169
Test instructions | Instructions pour tester la modification
Set up
Test 1
Edit your spreadsheetscreenTest 2