Feat/branding UI tests #1773
Open
Feat/branding UI tests #1773
+1,095
−188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…low to new feature
…out keeping track
…he GOC and pool pages
…r arbitrary branding
…email template preview
- Small refactor on file name - Added some more testids - Started some groundwork for expanding tests on the service settings page
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
|
||
| import config from "../../../../config"; | ||
| import ServiceSettingsPage from "../../../Notify/Admin/Pages/ServiceSettingsPage"; | ||
| import { EditBranding, BrandingSettings } from "../../../Notify/Admin/Pages/AllPages"; |
Check notice
Code scanning / CodeQL
Unused variable, import, function or class Note
- Only working locally at the moment. Need to add env variables for different environments
andrewleith
commented
Mar 27, 2024
There was a problem hiding this comment.
A couple of changes needed for content/design changes that have occurred.
For the review pool tests, the Saves the selected custom logo test is failing and I noticed that one of the components returns all the radio options as an array and then tries to click it, perhaps you meant to select just one?
AvailableLogoRadios: () => cy.get('input[id*="pool_branding-"]'),
Co-authored-by: Andrew <andrew.leith@cds-snc.ca>
- Added more data-testids - Make a couple tests less reliant on page content - Improve logging around Redis tasks
- added additional data-testid
- Add /branding page to the list of branding routes for a11y
- Since the github CI runner does not have direct access to redis, the previous method of connecting directly to redis to clear the cache is not viable. - Use admin user to navigate to the admin panel to clear the cache when we test the review pool page for empty and non-empty lists
🧪 Review environmenthttps://5y32oucomjgmyhcpj4wemory5e0ufqhr.lambda-url.ca-central-1.on.aws/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary | Résumé
This PR adds UI tests for the branding features
Test suites
Branding settings
Choose GOC brandings
Choose from pool
Preview Branding
Branding request tests