Disable var camelCaps name check (Squiz.NamingConventions.ValidVariableName.NotCamelCaps)

[simPod]

This rule conflicts with e.g. psalm's UnusedClosureParam, see https://psalm.dev/docs/running_psalm/issues/UnusedClosureParam/

[p4veI]

Not really sure what's more important if the psalm check or the cs check 🤷 but I guess I can live without the cs check.

[simPod]

It's rather an issue in the sniff that it cannot be configured. This one is already excluded in many of our projects. Disabling the whole psalm rule because of this is not worth it IMO.

…

On Fri, Jan 7, 2022, 11:19 Pavel Karfík ***@***.***> wrote: Not really sure what's more important if the psalm check or the cs check 🤷 but I guess I can live without the cs check. — Reply to this email directly, view it on GitHub <#61 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AACQAJJ5HJI7Q35HN2NNI4TUU242ZANCNFSM5LONROBQ> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>. You are receiving this because you authored the thread.Message ID: ***@***.***>

[grongor]

I think we should contribute to the sniff - add an option to allow _ names.

[simPod]

@grongor I can create an issue to track it. Though not happening anytime soon (In phpcs there's a lot of work around PHP 8.1, e.g. this is still not reviewed squizlabs/PHP_CodeSniffer#3459).

For our v6 this should be excluded (as we do so anyways in projects locally) and we can re-include it later when it does not conflict with SA.