Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add NZISM3.6 #1431

Open
wants to merge 86 commits into
base: main
Choose a base branch
from
Open

feat: Add NZISM3.6 #1431

wants to merge 86 commits into from

Conversation

mrpackethead
Copy link

@mrpackethead mrpackethead commented Sep 4, 2023

Fixes #1067

Reverted to using IMDVSv2 rule, that has been created.
Fixed bug in ec2securitygroupOnlyTcp443
Added ruleSuffixOverideNames

@mergify mergify bot mentioned this pull request Sep 4, 2023
Copy link
Collaborator

@dontirun dontirun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Initial review. Additionally noting that the RULES and README files need to updated after these are addressed

src/packs/nzism-v36-1022-20.ts Outdated Show resolved Hide resolved
src/packs/nzism-v36-1022-20.ts Outdated Show resolved Hide resolved
src/rules/s3/S3BucketServerSideEncryptionEnabled.ts Outdated Show resolved Hide resolved
src/rules/ec2/EC2SecurityGroupOnlyTcp443.ts Outdated Show resolved Hide resolved
src/rules/ec2/EC2SecurityGroupOnlyTcp443.ts Outdated Show resolved Hide resolved
src/packs/nzism-v36-1022-20.ts Outdated Show resolved Hide resolved
src/packs/nzism-v36-1022-20.ts Outdated Show resolved Hide resolved
src/packs/nzism-v36-1022-20.ts Outdated Show resolved Hide resolved
src/packs/nzism-v36-1022-20.ts Outdated Show resolved Hide resolved
src/packs/nzism-v36-1022-20.ts Outdated Show resolved Hide resolved
RULES.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
RULES.md Outdated Show resolved Hide resolved
RULES.md Show resolved Hide resolved
RULES.md Show resolved Hide resolved
mrpackethead and others added 19 commits September 21, 2023 06:26
Co-authored-by: Arun Donti <dontirun@gmail.com>
Co-authored-by: Arun Donti <dontirun@gmail.com>
Co-authored-by: Arun Donti <dontirun@gmail.com>
Co-authored-by: Arun Donti <dontirun@gmail.com>
Co-authored-by: Arun Donti <dontirun@gmail.com>
Co-authored-by: Arun Donti <dontirun@gmail.com>
Co-authored-by: Arun Donti <dontirun@gmail.com>
Co-authored-by: Arun Donti <dontirun@gmail.com>
Co-authored-by: Arun Donti <dontirun@gmail.com>
Co-authored-by: Arun Donti <dontirun@gmail.com>
Co-authored-by: Arun Donti <dontirun@gmail.com>
Co-authored-by: Arun Donti <dontirun@gmail.com>
Co-authored-by: Arun Donti <dontirun@gmail.com>
Co-authored-by: Arun Donti <dontirun@gmail.com>
Co-authored-by: Arun Donti <dontirun@gmail.com>
Co-authored-by: Arun Donti <dontirun@gmail.com>
Co-authored-by: Arun Donti <dontirun@gmail.com>
Co-authored-by: Arun Donti <dontirun@gmail.com>
Co-authored-by: Arun Donti <dontirun@gmail.com>
mrpackethead and others added 29 commits September 21, 2023 08:03
Co-authored-by: Arun Donti <dontirun@gmail.com>
Co-authored-by: Arun Donti <dontirun@gmail.com>
Co-authored-by: Arun Donti <dontirun@gmail.com>
Co-authored-by: Arun Donti <dontirun@gmail.com>
Co-authored-by: Arun Donti <dontirun@gmail.com>
Co-authored-by: Arun Donti <dontirun@gmail.com>
Co-authored-by: Arun Donti <dontirun@gmail.com>
Co-authored-by: Arun Donti <dontirun@gmail.com>
Co-authored-by: Arun Donti <dontirun@gmail.com>
Co-authored-by: Arun Donti <dontirun@gmail.com>
Co-authored-by: Arun Donti <dontirun@gmail.com>
Co-authored-by: Arun Donti <dontirun@gmail.com>
Co-authored-by: Arun Donti <dontirun@gmail.com>
Co-authored-by: Arun Donti <dontirun@gmail.com>
Co-authored-by: Arun Donti <dontirun@gmail.com>
Co-authored-by: Arun Donti <dontirun@gmail.com>
Co-authored-by: Arun Donti <dontirun@gmail.com>
Co-authored-by: Arun Donti <dontirun@gmail.com>
Co-authored-by: Arun Donti <dontirun@gmail.com>
Co-authored-by: Arun Donti <dontirun@gmail.com>
Co-authored-by: Arun Donti <dontirun@gmail.com>
Co-authored-by: Arun Donti <dontirun@gmail.com>
Co-authored-by: Arun Donti <dontirun@gmail.com>
Co-authored-by: Arun Donti <dontirun@gmail.com>
Co-authored-by: Arun Donti <dontirun@gmail.com>
Co-authored-by: Arun Donti <dontirun@gmail.com>
Co-authored-by: Arun Donti <dontirun@gmail.com>
Co-authored-by: Arun Donti <dontirun@gmail.com>
| NZISM3.6-SecretsManagerUsingKMSKey | The secret is not encrypted with a KMS Customer managed key. | To help protect data at rest, ensure encryption with AWS Key Management Service (AWS KMS) is enabled for AWS Secrets Manager secrets. Because sensitive data can exist at rest in Secrets Manager secrets, enable encryption at rest to help protect that data | 22.1.24.C.04[CID:4839] |
| NZISM3.6-SNSEncryptedKMS | The SNS topic does not have KMS encryption enabled. | To help protect data at rest, ensure that your Amazon Simple Notification Service (Amazon SNS) topics require encryption using AWS Key Management Service (AWS KMS) Because sensitive data can exist at rest in published messages, enable encryption at rest to help protect that data | 22.1.24.C.04[CID:4839] |
| NZISM3.6-EC2SecurityGroupOnlyTcp443 | Only port tcp 443 shoudl be permitted in ingress security group. | Not allowing ingress (or remote) traffic to ports other than tcp port 443 helps improve security | 18.1.13.C.02[CID:3205] |
| Rule ID | Cause | Explanation | Relevent Control ID(s) |
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Relevant Control ID(s) should follow the format from above

example SHOULD(16.6.10.C.02[CID:2013], 20.4.4.C.02[CID:4441], 20.4.5.C.02[CID:4445]), MUST(23.5.11.C.01[CID:7496])

| NZISM3.6-VPCDefaultSecurityGroupClosed | The VPC does not have an associated Flow Log. | The VPC flow logs provide detailed records for information about the IP traffic going to and from network interfaces in your Amazon |
| NZSISM3.6-VPCFlowLogs | VPC does not have an Assocated Flow Log. | Enable a Flow Log for the VPC | 19.1.12.C.01[CID:3562], 23.4.10.C.01[CID:7466] |
| NZISM3.6-WAFv2LoggingEnabled | The WAFv2 web ACL does not have logging enabled. | AWS WAF logging provides detailed information about the traffic that is analyzed by your web ACL. The logs record the time that AWS WAF received the request from your AWS resource, information about the request, and an action for the rule that each request matched. | [CID:2013], 23.5.11.C.01[CID:7496] |
| Rule ID | Cause | Explanation | Relevent Control ID(s) |
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Relevent -> Relevant

| NZISM3.6-WAFv2LoggingEnabled | The WAFv2 web ACL does not have logging enabled. | AWS WAF logging provides detailed information about the traffic that is analyzed by your web ACL. The logs record the time that AWS WAF received the request from your AWS resource, information about the request, and an action for the rule that each request matched. | [CID:2013], 23.5.11.C.01[CID:7496] |
| Rule ID | Cause | Explanation | Relevent Control ID(s) |
| ------------------------------------------------------- | --------------------------------------------------------------------------------------------------------------------------------------------------------- | --------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- | ------------------------------------------------------------------------------------------------------------------------------------- |
| NZISM3.6-APIGWExecutionLoggingEnabled | The API Gateway stage does not have execution logging enabled for all methods. | API Gateway logging displays detailed views of users who accessed the API and the way they accessed the API. This insight enables visibility of user activities. | Control IDs: SHOULD(16.6.10.C.02[CID:2013]), MUST(23.5.11.C.01[CID:7496]) |
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the column name is Relevant Control ID(s) we can remove the Control IDs: text from each of the individual rules

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: Include a Nag Pack for NZISM 3.6
2 participants