fix(typewriter): export property is ignored for FreeFunctions
#1079
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Francis <colifran@amazon.com>
Signed-off-by: Francis <colifran@amazon.com>
|
@aws-cdk/aws-service-spec: No model change detected |
mrgrain
reviewed
May 10, 2024
| @@ -411,11 +411,11 @@ export class TypeScriptRenderer extends Renderer { | |||
| throw new Error(`Symbol ${sym} (in ${sym.scope}) not visible from ${this.scopes[0]} (missing import?)`); | |||
| } | |||
|
|
|||
| protected renderFunction(func: CallableDeclaration) { | |||
| protected renderFunction(func: FreeFunction) { | |||
There was a problem hiding this comment.
This interface change makes be a little anxious. Are you sure this won't cause any issues?
renderFunction is protected, so we should be able to reason about this question from the code paths.
mrgrain
approved these changes
May 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
exportproperty is ignored when rendering aFreeFunction. We currently just render theFreeFunctionwithout considering if the function should be exported:awscdk-service-spec/packages/@cdklabs/typewriter/src/renderer/typescript.ts
Line 418 in 4ec0db4
This PR updates the
renderFunctionfunction to accept aFreeFunctiontype allowing us to check the value of theexportproperty. Ifexportis true then an export modifier is added in front of the function definition.