Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: notice for https://github.com/aws/aws-cdk/issues/30241 #503

Merged
merged 2 commits into from
May 16, 2024
Merged

chore: notice for https://github.com/aws/aws-cdk/issues/30241 #503

merged 2 commits into from
May 16, 2024

Conversation

SankyRed
Copy link
Contributor

Fixes # 30093

colifran
colifran reviewed May 16, 2024
View reviewed changes
data/notices.json Outdated Show resolved Hide resolved
colifran
colifran reviewed May 16, 2024
View reviewed changes
data/notices.json Outdated Show resolved Hide resolved
colifran
colifran requested changes May 16, 2024
View reviewed changes
Copy link
Contributor

@colifran colifran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to make sure we're giving enough context in the overview.

@SankyRed
Copy link
Contributor Author

We need to make sure we're giving enough context in the overview.

Updated the change as per suggestion. Thanks @colifran

@SankyRed SankyRed requested a review from colifran May 16, 2024 21:46
@mergify mergify bot merged commit 1d79709 into main May 16, 2024
7 checks passed
@mergify mergify bot deleted the SankyRed/diff-notice branch May 16, 2024 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colifran colifran colifran approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@SankyRed @colifran