-
-
Notifications
You must be signed in to change notification settings - Fork 7.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(typescript) - add typescript runtime test #22276
base: master
Are you sure you want to change the base?
Conversation
pcriadoperez
commented
Apr 25, 2024
•
edited
edited
- Add tests to import ccxt and compile typescript project using commonjs and esnext
- Fixes type errors that showed up during compile
also the build is not working |
@@ -413,7 +413,7 @@ export default class hyperliquid extends hyperliquidRest { | |||
} | |||
if (!(timeframe in this.ohlcvs[symbol])) { | |||
const limit = this.safeInteger (this.options, 'OHLCVLimit', 1000); | |||
const stored = new ArrayCacheByTimestamp (limit); | |||
const stored = new ArrayCacheByTimestamp<OHLCV> (limit); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pcriadoperez Question, don't we need to update every place where we initialize these structures?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is not needed as it defaults to unknown, but I'll add it as it's good practice. I also added that you can only add an item of the same type as the array
@pcriadoperez humm locally I get this error after
|
Runs |