Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix parseLeverageTiers #16299

Merged
merged 1 commit into from Jan 2, 2023
Merged

fix parseLeverageTiers #16299

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion js/base/Exchange.js
View file
Open in desktop
Expand Up @@ -1867,7 +1867,7 @@ module.exports = class Exchange {
for (let i = 0; i < response.length; i++) {
const item = response[i];
const id = this.safeString (item, marketIdKey);
const market = this.safeMarket (id);
const market = this.safeMarket (id, undefined, undefined, this.safeString (this.options, 'defaultType'));
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@frosty00 that's why I think we should default to defaultType inside safeMarket, we end up having to do this, which is virtually the same

const symbol = market['symbol'];
const contract = this.safeValue (market, 'contract', false);
if (contract && ((symbols === undefined) || this.inArray (symbol, symbols))) {
Expand Down