Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

woo: add edit order #16059

Merged
merged 5 commits into from Jan 4, 2023
Merged

woo: add edit order #16059

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a0ce43c
woo: add endpoints to edit order
sc0Vu Dec 12, 2022
2b482e4
woo: add editOrder
sc0Vu Dec 12, 2022
9487ea0
woo: update
sc0Vu Dec 12, 2022
f7d1633
woo: update signature
sc0Vu Dec 13, 2022
f9d575c
woo: update signature
sc0Vu Dec 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
80 changes: 66 additions & 14 deletions js/woo.js
View file
Open in desktop
Expand Up @@ -200,6 +200,12 @@ module.exports = class woo extends Exchange {
'post': {
'algo/order': 5,
},
'put': {
'order/{oid}': 2,
'order/client/{oid}': 2,
'algo/order/{oid}': 2,
'algo/order/client/{oid}': 2,
},
'delete': {
'algo/order/{oid}': 1,
'algo/orders/pending': 1,
Expand Down Expand Up @@ -773,6 +779,50 @@ module.exports = class woo extends Exchange {
);
}

async editOrder (id, symbol, type, side, amount, price = undefined, params = {}) {
/**
* @method
* @name woo#editOrder
* @description edit a trade order
* @param {string} id order id
* @param {string} symbol unified symbol of the market to create an order in
* @param {string} type 'market' or 'limit'
* @param {string} side 'buy' or 'sell'
* @param {float} amount how much of currency you want to trade in units of base currency
* @param {float|undefined} price the price at which the order is to be fullfilled, in units of the quote currency, ignored in market orders
* @param {object} params extra parameters specific to the woo api endpoint
* @returns {object} an [order structure]{@link https://docs.ccxt.com/en/latest/manual.html#order-structure}
*/
await this.loadMarkets ();
const market = this.market (symbol);
const request = {
'oid': id,
// 'quantity': this.amountToPrecision (symbol, amount),
// 'price': this.priceToPrecision (symbol, price),
};
if (price !== undefined) {
request['price'] = this.priceToPrecision (symbol, price);
}
if (amount !== undefined) {
request['quantity'] = this.amountToPrecision (symbol, amount);
}
const response = await this.v3PrivatePutOrderOid (this.extend (request, params));
//
// {
// "code": 0,
// "data": {
// "status": "string",
// "success": true
// },
// "message": "string",
// "success": true,
// "timestamp": 0
// }
//
const data = this.safeValue (response, 'data', {});
return this.parseOrder (data, market);
}

async cancelOrder (id, symbol = undefined, params = {}) {
/**
* @method
Expand Down Expand Up @@ -1789,39 +1839,41 @@ module.exports = class woo extends Exchange {
sign (path, section = 'public', method = 'GET', params = {}, headers = undefined, body = undefined) {
const version = section[0];
const access = section[1];
const pathWithParams = this.implodeParams (path, params);
let url = this.implodeHostname (this.urls['api'][access]);
url += '/' + version + '/';
path = this.implodeParams (path, params);
params = this.omit (params, this.extractParams (path));
params = this.keysort (params);
if (access === 'public') {
url += access + '/' + path;
url += access + '/' + pathWithParams;
if (Object.keys (params).length) {
url += '?' + this.urlencode (params);
}
} else {
this.checkRequiredCredentials ();
url += path;
let auth = '';
const ts = this.nonce ().toString ();
let auth = this.urlencode (params);
if (version === 'v3' && (method === 'POST')) {
url += pathWithParams;
headers = {
'x-api-key': this.apiKey,
'x-api-timestamp': ts,
};
if (version === 'v3' && (method === 'POST' || method === 'PUT' || method === 'DELETE')) {
auth = this.json (params);
body = auth;
auth = ts + method + '/' + version + '/' + path + body;
auth = ts + method + '/' + version + '/' + pathWithParams + body;
headers['content-type'] = 'application/json';
} else {
if (method === 'POST' || method === 'DELETE') {
auth = this.urlencode (params);
if (method === 'POST' || method === 'PUT' || method === 'DELETE') {
body = auth;
} else {
url += '?' + auth;
}
auth += '|' + ts;
headers['content-type'] = 'application/x-www-form-urlencoded';
}
const signature = this.hmac (this.encode (auth), this.encode (this.secret), 'sha256');
headers = {
'x-api-key': this.apiKey,
'x-api-signature': signature,
'x-api-timestamp': ts,
'Content-Type': 'application/x-www-form-urlencoded',
};
headers['x-api-signature'] = this.hmac (this.encode (auth), this.encode (this.secret), 'sha256');
}
return { 'url': url, 'method': method, 'body': body, 'headers': headers };
}
Expand Down