New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TICK_SIZE - waves.exchange #13689
Open
ttodua
wants to merge
14
commits into
ccxt:master
Choose a base branch
from
ttodua:ticksize-wavesexchange
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
TICK_SIZE - waves.exchange #13689
+122
−111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ttodua
force-pushed
the
ticksize-wavesexchange
branch
from
June 10, 2022 20:09
418f9fc
to
8bf0d09
Compare
kroitor
reviewed
Jun 15, 2022
ttodua
force-pushed
the
ticksize-wavesexchange
branch
from
July 4, 2022 16:11
30005a0
to
a7e2338
Compare
@kroitor I've run private tests (no issues) and also made a test order (works as expected). |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as outdated.
This comment was marked as outdated.
ttodua
force-pushed
the
ticksize-wavesexchange
branch
from
May 15, 2024 06:40
7aa8861
to
65bbd05
Compare
@carlosmiei passes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR updates the too old implementation of complex custom precision manipulations (the last edits were 4 years old, probably the Precise class was not developed well by that time).
This PR solves:
moves exchange from
DECIMAL_PLACES
toTICK_SIZE
.there were many scattered methods in the implementation:
customPriceToPrecision, customAmountToPrecision, customCurrencyToPrecision, fromPrecision, toPrecision, currencyFromPrecision, priceFromPrecision ... 🤯
.Now I've implemented the simpler :
fromReal / toReal
methods (for marketamount & price
and currencyamount
)