precisionFromString update #14206
Merged
precisionFromString update #14206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
all methods / langs are ready now to be merged. |
|
@ttodua the edits in this PR broke the build, can you take a look? |
|
ttodua
commented
Dec 30, 2022
| return str.length * -1 | ||
| } | ||
| // default strings like '0.0001' | ||
| const split = str.replace (/0+$/g, '').split ('.') |
There was a problem hiding this comment.
this 101th and next line was not touched.
ttodua
force-pushed
the
precisionFromString-update
branch
from
d18b7e0
to
8589c52
Compare
ttodua
force-pushed
the
precisionFromString-update
branch
from
8589c52
to
f33592a
Compare
|
@carlosmiei fixed. please review now. |
|
LGTM ✅ |
carlosmiei
approved these changes
Jan 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
base function
precisionFromStringworks with such numbers'0.001'but not with'1e-3'.so, this update is needed