Update "seek of closed file" fix for current django-storages #6
Conversation
Using this class with the new django-storages gives the error: ValueError: seek of closed file This change should fix that - jschneier/django-storages#382 (comment)
nikolas
force-pushed
the
update-closedfile-fix
branch
from
d23f1cb
to
8101408
Compare
| # Fix for "ValueError: seek of closed file" problem with boto3 | ||
| # https://github.com/jschneier/django-storages/issues/382#issuecomment-377174808 | ||
| def _save_content(self, obj, content, parameters): | ||
| # https://github.com/jschneier/django-storages/issues/382 |
There was a problem hiding this comment.
If this is removed completely, will it just pick up the one in django-storages?
There was a problem hiding this comment.
Hmmmm, good point.. maybe the fix is already in I may be getting confused. Let me see if I can reproduce this locally with ./manage.py compress to test that.
There was a problem hiding this comment.
Okay, so when testing this locally (actually with ./manage.py collectstatic):
When I remove the _save/_save_content override completely, I get the same error:
File "/home/nik/src/d/mediathread/ve/lib64/python3.7/site-packages/django/core/files/base.py", line 55, in chunks
self.seek(0)
ValueError: seek of closed file
With this change.... well it's still running and not showing any output yet. I'll see what happens, but looks promising.
There was a problem hiding this comment.
Okay, yes. It's actually copying the files successfully with this override (when you do ./manage.py collectstatic -v 3)... which unfortunately still seems necessary.
Using this class with the new django-storages gives the error:
ValueError: seek of closed file
This change should fix that -
jschneier/django-storages#382 (comment)