-
-
Notifications
You must be signed in to change notification settings - Fork 247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: use vite to bundle deps at main/preload package under ssr mode. #904
Conversation
The dev/prod build was successful on my Windows 10 env. The tests failed because of vitest-dev/vitest#2806 . |
|
No. module.exports = [
// API root
'electron',
// common modules
'clipboard',
'crash-reporter',
'deprecations',
'nativeImage',
'shell',
// ...
]; All modules besides import { clipboard } from 'electron' But never import * as clipboard from 'clipboard' So we just need to externalize |
Note: If you turned off |
Hello. I apologize for the delay. Due to... known reasons... I have very little free time. I plan to merge this. But I'd like to wait until the vitest-dev/vitest#2806 issue is resolved so as not to confuse users. Also, I feel that there needs to be some kind of additional documentation in the readme to explain how dependencies work and how they are bundled and delivered to the end user. |
rollup/rollup#4905 is fixed. |
Hello. Thank you again for the fantastic job you did. I still think this is a good idea and will definitely keep an eye on it. Unfortunately, due to the war in my country, I have less and less energy to maintain this project. Recently, major changes have taken place and I have moved this template entirely to the ESM. In this regard, I consider the implementation in this PR to be outdated and conflicted. I will close it now and try to return to it at some point. |
See previous try #903 for more details.