Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: DOS-625 Address action execution blocking new requests #189

Merged
merged 2 commits into from
Feb 6, 2024
Merged

Fix: DOS-625 Address action execution blocking new requests #189

merged 2 commits into from
Feb 6, 2024

Commits on Feb 6, 2024

  1. Fix: DOS-625 Address action execution blocking new requests 

    * The usage of BackgroundTasks in the new execute_action code was found to be causing blockages of new requests being picked up by the event loop. I think this maybe a reccurance of encode/starlette#919 which they claim is resolved, but still doesn't appear to be working for us. It may be due to one of our middlewares behaving in a particular way that causes this, but the fix applied here appears to be the simplest fix for now.
* In this instance we have replaced the usage of background_tasks.add_task with asyncio.create_task that will run the task in the loop without worrying about its result.
    @sam-causalens
    sam-causalens committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    7dac931 View commit details
    Browse the repository at this point in the history

  2. Fix linting

    @sam-causalens
    sam-causalens committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    a9850f3 View commit details
    Browse the repository at this point in the history