perf(element): add one sweep element creation

[j-mendez]

1. major performance improvements on element creation

[j-mendez]

@cfvescovo re-verted a.value.deref() back to prior. Can take a look later on updating to a match later or etc.

[cfvescovo]

Maybe we could match a.name.local.deref() and check if it is equal to id or class. The call to a.value().deref() should be inside each arm of our match. Performing it inside the match is better since it will only be called if needed (at most once per iteration).

[j-mendez]

Maybe we could match a.name.local.deref() and check if it is equal to id or class. The call to a.value().deref() should be inside each arm of our match. Performing it inside the match is better since it will only be called if needed (at most once per iteration).

I like that, feel free to hop on the PR and make those changes or any, need to brb.

[j-mendez]

was rushing and made this change without thinking. @adamreichold @cfvescovo feel free to squash the commits for this PR.

[cfvescovo]

Will do, thanks

[cfvescovo]

Maybe we could match a.name.local.deref() and check if it is equal to id or class. The call to a.value().deref() should be inside each arm of our match. Performing it inside the match is better since it will only be called if needed (at most once per iteration).

I like that, feel free to hop on the PR and make those changes or any, need to brb.

I do not think I have permissions to edit this PR

[j-mendez]

match a.name.local.deref()

ok, ill make the changes really quick should be simple

[j-mendez]

Maybe we could match a.name.local.deref() and check if it is equal to id or class. The call to a.value().deref() should be inside each arm of our match. Performing it inside the match is better since it will only be called if needed (at most once per iteration).

I like that, feel free to hop on the PR and make those changes or any, need to brb.

I do not think I have permissions to edit this PR

@cfvescovo updated

[cfvescovo]

@j-mendez thank you