An Error Type for Selector::parse
#95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM even though some readability improvements would be welcome |
|
I think it makes sense to implement Error for this type. |
|
I would really appreciate if this fork gets merged ASAP as I need these changes to continue working on a project |
Kiwifuit
commented
Dec 18, 2022
|
Looking into this rn, will be back ASAP |
cfvescovo
reviewed
Dec 19, 2022
Only did code which I touched, though
cfvescovo
reviewed
Dec 19, 2022
cfvescovo
reviewed
Dec 19, 2022
cfvescovo
requested changes
Dec 19, 2022
Forgot this is already a `String`
cfvescovo
reviewed
Dec 19, 2022
cfvescovo
approved these changes
Dec 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I might be adding different error types if needed, but for now the error type for
Selector::parse'sResultis now a custom type that is exported.This PR resolves #60
Improvements to the code are welcome