You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Some returned Results returned by scraper functions use error types from the cssparser crate.
Unfortunately in my project, I cannot handle them (e.g. using thiserror) without adding cssparser to my dependencies as well, even though I don't need it anywhere else.
Please consider reexporting cssparser, or alternatively define error types for the scraper crate and export those.
Let's define a common error struct for scraper so that crates using it can integrate it in their error handling.
The text was updated successfully, but these errors were encountered:
Sounds good, yeah. It solves the same issue, so feel free to see this as the solution of this ticket.
jannisbecker
changed the title
Consider reexporting crates of which errors are returned
Consider exporting common errors thrown by this crate
Apr 19, 2021
Some returned
Result
s returned by scraper functions use error types from thecssparser
crate.Unfortunately in my project, I cannot handle them (e.g. using
thiserror
) without addingcssparser
to my dependencies as well, even though I don't need it anywhere else.Please consider reexporting cssparser, or alternatively define error types for the scraper crate and export those.Let's define a common error struct for
scraper
so that crates using it can integrate it in their error handling.The text was updated successfully, but these errors were encountered: