Move header from internal #2867
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move `catch_case_sensitive.hpp` from directory `src/catch2/internal/internal` to be directly under `src/catch2/`. Header `catch_case_sensitive.hpp` defines `enum CaseSensitive` which is part of the public API, since it is exposed by the string matcher contracts. Fixes issue caught by Clang Tidy misc-include-cleaner check.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## devel #2867 +/- ##
==========================================
+ Coverage 90.99% 91.03% +0.04%
==========================================
Files 198 198
Lines 8391 8391
==========================================
+ Hits 7635 7638 +3
+ Misses 756 753 -3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move
catch_case_sensitive.hppfrom directorysrc/catch2/internal/internalto be directly undersrc/catch2/.Header
catch_case_sensitive.hppdefinesenum CaseSensitivewhich is part of the public API, since it is exposed by the string matcher contracts.Fixes issue caught by Clang Tidy misc-include-cleaner check.