Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/edit pull request template #955

Merged

Conversation

zkid18
Copy link
Contributor

@zkid18 zkid18 commented Oct 8, 2020

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contribution guide?
  • Did you check the code style? catalyst-make-codestyle && catalyst-check-codestyle (pip install -U catalyst-codestyle).
  • Did you make sure to update the docs? We use Google format for all the methods and classes.
  • Did you check the docs with make check-docs?
  • Did you write any new necessary tests?
  • Did you add your new functionality to the docs?
  • Did you update the CHANGELOG?
  • You can use 'Login as guest' to see Teamcity build logs.

Description

Related Issue

Type of Change

  • Examples / docs / tutorials / contributors update
  • Bug fix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves an existing feature)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

@pep8speaks
Copy link

Hello @zkid18! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 11:1: E302 expected 2 blank lines, found 1
Line 15:1: W293 blank line contains whitespace
Line 17:67: W291 trailing whitespace
Line 18:54: W291 trailing whitespace
Line 19:80: E501 line too long (86 > 79 characters)
Line 22:79: W291 trailing whitespace
Line 50:37: W291 trailing whitespace
Line 55:13: E126 continuation line over-indented for hanging indent
Line 57:13: E123 closing bracket does not match indentation of opening bracket's line
Line 61:5: E303 too many blank lines (2)
Line 83:1: W293 blank line contains whitespace
Line 100:20: E251 unexpected spaces around keyword / parameter equals
Line 100:22: E251 unexpected spaces around keyword / parameter equals
Line 101:30: E251 unexpected spaces around keyword / parameter equals
Line 101:32: E251 unexpected spaces around keyword / parameter equals
Line 101:32: W291 trailing whitespace
Line 106:17: E128 continuation line under-indented for visual indent
Line 110:1: W293 blank line contains whitespace
Line 110:1: W391 blank line at end of file

- [ ] Did you add your new functionality to the docs?
- [ ] Did you update the [CHANGELOG](https://github.com/catalyst-team/catalyst/CHANGELOG.md)?
- [ ] Did you update the [CHANGELOG](https://github.com/catalyst-team/catalyst/blob/master/CHANGELOG.md)?
- [x] **You can use 'Login as guest' to see Teamcity build logs.**
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

btw, could you also remove this line, as far as it's deprecated already?)

Suggested change
- [x] **You can use 'Login as guest' to see Teamcity build logs.**

@Scitator Scitator merged commit f9b68b6 into catalyst-team:master Oct 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants