Arch update - `20.10` #953

Scitator · 2020-10-06T06:37:37Z

Before submitting

Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
Did you read the contribution guide?
Did you check the code style? catalyst-make-codestyle && catalyst-check-codestyle (pip install -U catalyst-codestyle).
Did you make sure to update the docs? We use Google format for all the methods and classes.
Did you check the docs with make check-docs?
Did you write any new necessary tests?
Did you add your new functionality to the docs?
Did you update the CHANGELOG?
You can use 'Login as guest' to see Teamcity build logs.

Description

Related Issue

Type of Change

Examples / docs / tutorials / contributors update
Bug fix (non-breaking change which fixes an issue)
Improvement (non-breaking change which improves an existing feature)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

github-actions · 2020-10-06T06:45:52Z

catalyst/core/callbacks/exception.py

-    def on_exception(self, runner: IRunner):
-        """@TODO: Docs. Contribution is welcome."""
+    def on_exception(self, runner: IRunner) -> None:
+        """Exception handle hook.


[pep8] _{reported by reviewdog 🐶}
DAR401 Missing exception(s) in Raises section: -r exception

github-actions · 2020-10-06T07:22:40Z

catalyst/utils/loaders.py

 from catalyst.registry import SAMPLER
 from catalyst.utils import get_rank, merge_dicts, set_global_seed

+from typing import Dict, Union  # isort:skip


[pep8] _{reported by reviewdog 🐶}
F811 redefinition of unused 'Dict' from line 1

github-actions · 2020-10-06T07:22:40Z

catalyst/callbacks/exception.py

-    def on_exception(self, runner: IRunner):
-        """@TODO: Docs. Contribution is welcome."""
+    def on_exception(self, runner: IRunner) -> None:
+        """Exception handle hook.


[pep8] _{reported by reviewdog 🐶}
DAR401 Missing exception(s) in Raises section: -r exception

github-actions · 2020-10-11T09:27:23Z

catalyst/settings.py

@@ -338,11 +338,15 @@ def parse(self) -> dict:
        return config


-settings = Settings.parse()
+SETTINGS = Settings.parse()
+setattr(SETTINGS, "IS_GIT_AVAILABLE", IS_GIT_AVAILABLE)


[pep8] _{reported by reviewdog 🐶}
B010 Do not call setattr with a constant attribute value, it is not any safer than normal property access.

github-actions · 2020-10-11T09:27:23Z

catalyst/settings.py

-settings = Settings.parse()
+SETTINGS = Settings.parse()
+setattr(SETTINGS, "IS_GIT_AVAILABLE", IS_GIT_AVAILABLE)
+setattr(SETTINGS, "IS_XLA_AVAILABLE", IS_XLA_AVAILABLE)


[pep8] _{reported by reviewdog 🐶}
B010 Do not call setattr with a constant attribute value, it is not any safer than normal property access.

github-actions · 2020-10-11T09:27:24Z

catalyst/settings.py

+SETTINGS = Settings.parse()
+setattr(SETTINGS, "IS_GIT_AVAILABLE", IS_GIT_AVAILABLE)
+setattr(SETTINGS, "IS_XLA_AVAILABLE", IS_XLA_AVAILABLE)
+setattr(SETTINGS, "IS_PRUNING_AVAILABLE", IS_PRUNING_AVAILABLE)


[pep8] _{reported by reviewdog 🐶}
B010 Do not call setattr with a constant attribute value, it is not any safer than normal property access.

github-actions · 2020-10-11T09:27:24Z

catalyst/settings.py

+setattr(SETTINGS, "IS_GIT_AVAILABLE", IS_GIT_AVAILABLE)
+setattr(SETTINGS, "IS_XLA_AVAILABLE", IS_XLA_AVAILABLE)
+setattr(SETTINGS, "IS_PRUNING_AVAILABLE", IS_PRUNING_AVAILABLE)
+setattr(SETTINGS, "IS_QUANTIZATION_AVAILABLE", IS_QUANTIZATION_AVAILABLE)


[pep8] _{reported by reviewdog 🐶}
B010 Do not call setattr with a constant attribute value, it is not any safer than normal property access.

github-actions · 2020-10-11T09:27:24Z

catalyst/data/cv/reader.py

-        mask = utils.mimread(
-            mask_name, rootpath=self.rootpath, clip_range=self.clip
-        )
+        mask = mimread(mask_name, rootpath=self.rootpath, clip_range=self.clip)


[pep8] _{reported by reviewdog 🐶}
F821 undefined name 'mimread'

github-actions · 2020-10-11T09:27:24Z

catalyst/core/runner.py

-            scheduler,
-            device,
-        ) = utils.process_components(
+        (model, criterion, optimizer, scheduler, device,) = process_components(


[pep8] _{reported by reviewdog 🐶}
C819 trailing comma prohibited

mergify · 2020-10-11T11:58:12Z

This pull request is now in conflicts. @Scitator, could you fix it? 🙏

mergify · 2020-10-11T12:09:47Z

This pull request is now in conflicts. @Scitator, could you fix it? 🙏

github-actions · 2020-10-11T16:23:17Z

catalyst/experiments/tests/test_config.py

    SchedulerCallback,
    TensorboardLogger,
    ValidationManagerCallback,
 )
-from catalyst.dl.experiment.config import ConfigExperiment
+from catalyst import registry


[pep8] _{reported by reviewdog 🐶}
I001 isort found an import in the wrong position

github-actions · 2020-10-11T17:15:49Z

catalyst/settings.py

+setattr(SETTINGS, "IS_GIT_AVAILABLE", IS_GIT_AVAILABLE)  # noqa: B010
+setattr(SETTINGS, "IS_XLA_AVAILABLE", IS_XLA_AVAILABLE)  # noqa: B010
+setattr(SETTINGS, "IS_PRUNING_AVAILABLE", IS_PRUNING_AVAILABLE)  # noqa: B010
+setattr(


[pep8] _{reported by reviewdog 🐶}
B010 Do not call setattr with a constant attribute value, it is not any safer than normal property access.

github-actions · 2020-10-11T17:15:49Z

catalyst/experiments/experiment.py

@@ -1,35 +1,37 @@
-from typing import Any, Dict, Iterable, List, Mapping, Tuple, Union
+from typing import Any, Dict, Iterable, List, Mapping, Tuple, Union, TYPE_CHECKING


[pep8] _{reported by reviewdog 🐶}
I001 isort found an import in the wrong position

github-actions · 2020-10-11T17:15:50Z

catalyst/experiments/experiment.py

@@ -1,35 +1,37 @@
-from typing import Any, Dict, Iterable, List, Mapping, Tuple, Union
+from typing import Any, Dict, Iterable, List, Mapping, Tuple, Union, TYPE_CHECKING


[pep8] _{reported by reviewdog 🐶}
E501 line too long (82 > 79 characters)

github-actions · 2020-10-11T17:15:50Z

catalyst/callbacks/exception.py

+            runner: experiment runner
+
+        Raises:
+            Exception: if during exception handling,


[pep8] _{reported by reviewdog 🐶}
DAR402 Excess exception(s) in Raises section: +r Exception

…arch-update

docs update

febbb20

Scitator requested review from bagxi and ditwoo as code owners October 6, 2020 06:37

github-actions bot reviewed Oct 6, 2020

View reviewed changes

Scitator added 2 commits October 6, 2020 10:06

brace yourself; arch update is comming

bd4153e

one to many

4c9322a

github-actions bot reviewed Oct 6, 2020

View reviewed changes

Scitator added 2 commits October 6, 2020 10:25

nn

19f29e5

imports

10c33e2

github-actions bot reviewed Oct 11, 2020

View reviewed changes

Scitator added 3 commits October 11, 2020 13:24

imports2

fcd3843

imports3

3e3910d

imports4

9afa217

merged with master

4e13aae

Scitator added 14 commits October 11, 2020 15:14

merged with master 2

652ddd4

tests update

701ea76

tests update

d83b2f1

tests update

c21b90c

tests update

a41d6da

imports update

3e292fe

imports update

4e973d5

imports update

b9113da

imports update

1ad9b97

imports update

c24a0ca

imports update

ea05043

imports update

a9dcd88

docs update

5a65ca8

tests update

52b5149

github-actions bot reviewed Oct 11, 2020

View reviewed changes

Scitator added 2 commits October 11, 2020 20:06

tests update

5bcd074

tests update

322ec43

github-actions bot reviewed Oct 11, 2020

View reviewed changes

Scitator and others added 8 commits October 11, 2020 20:49

tests update

d3d257c

docs update

6a77eac

Merge branch 'master' of github.com:catalyst-team/catalyst into arch/…

c124450

…arch-update

backward compatibility

2ba7e90

docs updates

61b178c

renamed callback split names

c199570

changelog

2fe0b28

docs update

6061316

Scitator merged commit 1f13840 into master Oct 12, 2020

mergify bot deleted the arch/arch-update branch October 12, 2020 06:13

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Arch update - `20.10` #953

Arch update - `20.10` #953

Scitator commented Oct 6, 2020

github-actions bot Oct 6, 2020

github-actions bot Oct 6, 2020

github-actions bot Oct 6, 2020

github-actions bot Oct 11, 2020

github-actions bot Oct 11, 2020

github-actions bot Oct 11, 2020

github-actions bot Oct 11, 2020

github-actions bot Oct 11, 2020

github-actions bot Oct 11, 2020

mergify bot commented Oct 11, 2020

mergify bot commented Oct 11, 2020

github-actions bot Oct 11, 2020

github-actions bot Oct 11, 2020

github-actions bot Oct 11, 2020

github-actions bot Oct 11, 2020

github-actions bot Oct 11, 2020

		@@ -1,35 +1,37 @@
		from typing import Any, Dict, Iterable, List, Mapping, Tuple, Union
		from typing import Any, Dict, Iterable, List, Mapping, Tuple, Union, TYPE_CHECKING

Arch update - 20.10 #953

Arch update - 20.10 #953

Conversation

Scitator commented Oct 6, 2020

Before submitting

Description

Related Issue

Type of Change

PR review

github-actions bot Oct 6, 2020

Choose a reason for hiding this comment

github-actions bot Oct 6, 2020

Choose a reason for hiding this comment

github-actions bot Oct 6, 2020

Choose a reason for hiding this comment

github-actions bot Oct 11, 2020

Choose a reason for hiding this comment

github-actions bot Oct 11, 2020

Choose a reason for hiding this comment

github-actions bot Oct 11, 2020

Choose a reason for hiding this comment

github-actions bot Oct 11, 2020

Choose a reason for hiding this comment

github-actions bot Oct 11, 2020

Choose a reason for hiding this comment

github-actions bot Oct 11, 2020

Choose a reason for hiding this comment

mergify bot commented Oct 11, 2020

mergify bot commented Oct 11, 2020

github-actions bot Oct 11, 2020

Choose a reason for hiding this comment

github-actions bot Oct 11, 2020

Choose a reason for hiding this comment

github-actions bot Oct 11, 2020

Choose a reason for hiding this comment

github-actions bot Oct 11, 2020

Choose a reason for hiding this comment

github-actions bot Oct 11, 2020

Choose a reason for hiding this comment

Arch update - `20.10` #953

Arch update - `20.10` #953