New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: SoftMax, CosFace, ArcFace layers #939
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit
pep8
catalyst/contrib/nn/tests/test_criterion.py|2 col 1| I001 isort found an import in the wrong position
catalyst/contrib/nn/tests/test_criterion.py|7 col 1| I001 isort found an import in the wrong position
catalyst/contrib/nn/tests/test_criterion.py|27 col 1| D103 Missing docstring in public function
catalyst/contrib/nn/tests/test_criterion.py|63 col 5| F841 local variable 'feats' is assigned to but never used
from catalyst.contrib.nn.modules.arcface import ArcFace | ||
from catalyst.contrib.nn.modules.cosface import CosFace |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as far as this is criterions, could we move them to contrib/nn/criterion
? what do you think about this?
This pull request is now in conflicts. @ditwoo, could you fix it? 🙏 |
This pull request is now in conflicts. @ditwoo, could you fix it? 🙏 |
Before submitting
catalyst-make-codestyle && catalyst-check-codestyle
(pip install -U catalyst-codestyle
).make check-docs
?Description
Related Issue
Type of Change
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.