Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: SoftMax, CosFace, ArcFace layers #939

Merged
merged 25 commits into from Oct 2, 2020
Merged

Feature: SoftMax, CosFace, ArcFace layers #939

merged 25 commits into from Oct 2, 2020

Conversation

ditwoo
Copy link
Contributor

@ditwoo ditwoo commented Sep 14, 2020

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contribution guide?
  • Did you check the code style? catalyst-make-codestyle && catalyst-check-codestyle (pip install -U catalyst-codestyle).
  • Did you make sure to update the docs? We use Google format for all the methods and classes.
  • Did you check the docs with make check-docs?
  • Did you write any new necessary tests?
  • Did you add your new functionality to the docs?
  • Did you update the CHANGELOG?
  • You can use 'Login as guest' to see Teamcity build logs.

Description

Related Issue

Type of Change

  • Examples / docs / tutorials / contributors update
  • Bug fix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves an existing feature)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

@pep8speaks
Copy link

pep8speaks commented Sep 14, 2020

Hello @ditwoo! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2020-10-01 21:23:14 UTC

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

pep8

catalyst/contrib/nn/tests/test_criterion.py|2 col 1| I001 isort found an import in the wrong position
catalyst/contrib/nn/tests/test_criterion.py|7 col 1| I001 isort found an import in the wrong position
catalyst/contrib/nn/tests/test_criterion.py|27 col 1| D103 Missing docstring in public function
catalyst/contrib/nn/tests/test_criterion.py|63 col 5| F841 local variable 'feats' is assigned to but never used

catalyst/contrib/nn/criterion/cosface.py Outdated Show resolved Hide resolved
catalyst/contrib/nn/criterion/cosface.py Outdated Show resolved Hide resolved
catalyst/contrib/nn/criterion/cosface.py Outdated Show resolved Hide resolved
catalyst/contrib/nn/criterion/cosface.py Outdated Show resolved Hide resolved
catalyst/contrib/nn/criterion/cosface.py Outdated Show resolved Hide resolved
catalyst/contrib/nn/criterion/cosface.py Outdated Show resolved Hide resolved
catalyst/contrib/nn/criterion/cosface.py Outdated Show resolved Hide resolved
catalyst/contrib/nn/criterion/cosface.py Outdated Show resolved Hide resolved
catalyst/contrib/nn/criterion/cosface.py Outdated Show resolved Hide resolved
catalyst/contrib/nn/tests/test_criterion.py Outdated Show resolved Hide resolved
@ditwoo ditwoo added WIP Pull request is under construction enhancement New feature or request labels Sep 14, 2020
catalyst/contrib/nn/tests/test_criterion.py Show resolved Hide resolved
catalyst/contrib/nn/tests/test_criterion.py Outdated Show resolved Hide resolved
catalyst/contrib/nn/tests/test_criterion.py Outdated Show resolved Hide resolved
catalyst/contrib/nn/tests/test_criterion.py Outdated Show resolved Hide resolved
catalyst/contrib/nn/tests/test_criterion.py Outdated Show resolved Hide resolved
catalyst/contrib/nn/tests/test_criterion.py Show resolved Hide resolved
catalyst/contrib/nn/tests/test_criterion.py Show resolved Hide resolved
catalyst/contrib/nn/tests/test_criterion.py Outdated Show resolved Hide resolved
catalyst/contrib/nn/tests/test_criterion.py Outdated Show resolved Hide resolved
@ditwoo ditwoo changed the title cosface loss Feature: SoftMax, CosFace, ArcFace layers Sep 20, 2020
@ditwoo ditwoo marked this pull request as ready for review September 20, 2020 13:23
@ditwoo ditwoo removed the WIP Pull request is under construction label Sep 20, 2020
catalyst/contrib/nn/modules/arcface.py Outdated Show resolved Hide resolved
catalyst/contrib/nn/modules/cosface.py Outdated Show resolved Hide resolved
catalyst/contrib/nn/modules/softmax.py Outdated Show resolved Hide resolved
Comment on lines 36 to 37
from catalyst.contrib.nn.modules.arcface import ArcFace
from catalyst.contrib.nn.modules.cosface import CosFace
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as far as this is criterions, could we move them to contrib/nn/criterion? what do you think about this?

@mergify
Copy link

mergify bot commented Sep 22, 2020

This pull request is now in conflicts. @ditwoo, could you fix it? 🙏

@mergify
Copy link

mergify bot commented Sep 29, 2020

This pull request is now in conflicts. @ditwoo, could you fix it? 🙏

catalyst/contrib/nn/modules/arcface.py Outdated Show resolved Hide resolved
catalyst/contrib/nn/modules/arcface.py Outdated Show resolved Hide resolved
catalyst/contrib/nn/modules/arcface.py Outdated Show resolved Hide resolved
catalyst/contrib/nn/modules/arcface.py Outdated Show resolved Hide resolved
catalyst/contrib/nn/modules/arcface.py Outdated Show resolved Hide resolved
catalyst/contrib/nn/modules/arcface.py Show resolved Hide resolved
catalyst/contrib/nn/modules/cosface.py Outdated Show resolved Hide resolved
catalyst/contrib/nn/modules/cosface.py Outdated Show resolved Hide resolved
catalyst/contrib/nn/modules/cosface.py Outdated Show resolved Hide resolved
catalyst/contrib/nn/modules/softmax.py Outdated Show resolved Hide resolved
catalyst/contrib/nn/modules/arcface.py Outdated Show resolved Hide resolved
catalyst/contrib/nn/modules/arcface.py Outdated Show resolved Hide resolved
catalyst/contrib/nn/modules/arcface.py Outdated Show resolved Hide resolved
catalyst/contrib/nn/modules/arcface.py Outdated Show resolved Hide resolved
catalyst/contrib/nn/modules/arcface.py Outdated Show resolved Hide resolved
catalyst/contrib/nn/modules/arcface.py Show resolved Hide resolved
catalyst/contrib/nn/modules/arcface.py Show resolved Hide resolved
catalyst/contrib/nn/modules/arcface.py Outdated Show resolved Hide resolved
catalyst/contrib/nn/modules/arcface.py Outdated Show resolved Hide resolved
catalyst/contrib/nn/modules/arcface.py Outdated Show resolved Hide resolved
catalyst/contrib/nn/modules/arcface.py Outdated Show resolved Hide resolved
catalyst/contrib/nn/modules/arcface.py Outdated Show resolved Hide resolved
catalyst/contrib/nn/modules/arcface.py Outdated Show resolved Hide resolved
catalyst/contrib/nn/modules/arcface.py Outdated Show resolved Hide resolved
catalyst/contrib/nn/modules/arcface.py Outdated Show resolved Hide resolved
catalyst/contrib/nn/modules/arcface.py Outdated Show resolved Hide resolved
catalyst/contrib/nn/modules/arcface.py Outdated Show resolved Hide resolved
catalyst/contrib/nn/modules/arcface.py Outdated Show resolved Hide resolved
catalyst/contrib/nn/modules/arcface.py Outdated Show resolved Hide resolved
catalyst/contrib/nn/modules/arcface.py Outdated Show resolved Hide resolved
catalyst/contrib/nn/modules/arcface.py Outdated Show resolved Hide resolved
catalyst/contrib/nn/modules/arcface.py Outdated Show resolved Hide resolved
catalyst/contrib/nn/modules/arcface.py Outdated Show resolved Hide resolved
catalyst/contrib/nn/modules/softmax.py Outdated Show resolved Hide resolved
@Scitator Scitator merged commit 0744680 into master Oct 2, 2020
@mergify mergify bot deleted the feature/cosface branch October 2, 2020 05:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants