registries update #936
Merged
registries update #936
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bagxi
previously approved these changes
Sep 10, 2020
bagxi
previously requested changes
Sep 10, 2020
catalyst/contrib/utils/__init__.py
Outdated
|
|
||
| logger = logging.getLogger(__name__) | ||
|
|
||
| from catalyst.tools import settings |
There was a problem hiding this comment.
settings module is needed for "plotly no available" warning
catalyst/core/callbacks/logging.py
Outdated
| def _get_logger(logdir): | ||
| logger = logging.getLogger("metrics_logger") | ||
| def _get_logger(): | ||
| logger = logging.getLogger(f"metrics_logger") |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
catalyst/dl/scripts/run.py
Outdated
|
|
||
| experiment_params = config.get("experiment_params", {}) | ||
| experiment_from_config = experiment_params.get("experiment", None) | ||
| assert any( |
There was a problem hiding this comment.
[pep8] reported by reviewdog 🐶
C407 Unnecessary list comprehension - 'any' can take a generator.
catalyst/dl/scripts/run.py
Outdated
|
|
||
| runner_params = config.get("runner_params", {}) | ||
| runner_from_config = runner_params.get("runner", None) | ||
| assert any( |
There was a problem hiding this comment.
[pep8] reported by reviewdog 🐶
C407 Unnecessary list comprehension - 'any' can take a generator.
bagxi
previously requested changes
Sep 10, 2020
15 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting
catalyst-make-codestyle && catalyst-check-codestyle(pip install -U catalyst-codestyle).make check-docs?Description
Related Issue
Type of Change
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.