Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: test updates #881

Merged
merged 11 commits into from Jul 13, 2020
Merged

Fix: test updates #881

merged 11 commits into from Jul 13, 2020

Conversation

ditwoo
Copy link
Contributor

@ditwoo ditwoo commented Jul 12, 2020

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contribution guide?
  • Did you check the code style? catalyst-make-codestyle && catalyst-check-codestyle (pip install -U catalyst-codestyle).
  • Did you make sure to update the docs? We use Google format for all the methods and classes.
  • Did you check the docs with make check-docs?
  • Did you write any new necessary tests?
  • Did you add your new functionality to the docs?
  • Did you update the CHANGELOG?
  • You can use 'Login as guest' to see Teamcity build logs.

Description

Related Issue

Type of Change

  • Examples / docs / tutorials / contributors update
  • Bug fix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves an existing feature)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

@ditwoo ditwoo changed the title Updates in tests Fix: test updates & test speed ups Jul 12, 2020
@ditwoo ditwoo changed the title Fix: test updates & test speed ups Fix: test updates Jul 13, 2020
@ditwoo ditwoo closed this Jul 13, 2020
@ditwoo ditwoo reopened this Jul 13, 2020
@pep8speaks
Copy link

pep8speaks commented Jul 13, 2020 •
edited

Hello @ditwoo! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2020-07-13 17:22:18 UTC

@pep8speaks
Copy link

Hello @ditwoo! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 1:27: W292 no newline at end of file

@ditwoo ditwoo marked this pull request as ready for review July 13, 2020 16:03
Scitator
Scitator reviewed Jul 13, 2020
View reviewed changes
tests/_tests_dl_callbacks/config26.yml Outdated
@@ -43,6 +43,9 @@ stages:
accuracy_args: [1, 3, 5]
saver:
callback: CheckpointCallback
fast_run:
callback: CheckRunCallback
num_epoch_steps: 4
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

4?

Scitator
Scitator reviewed Jul 13, 2020
View reviewed changes
tests/_tests_dl_callbacks/config28.yml Outdated
@@ -43,6 +43,9 @@ stages:
accuracy_args: [1, 3, 5]
saver:
callback: CheckpointCallback
fast_run:
callback: CheckRunCallback
num_epoch_steps: 4
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

4?

@Scitator Scitator merged commit 2ef613b into catalyst-team:master Jul 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Scitator Scitator Scitator left review comments

@bagxi bagxi Awaiting requested review from bagxi bagxi is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ditwoo @pep8speaks @Scitator