extra sampler + docs #1262
extra sampler + docs #1262
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
catalyst/data/sampler.py
Outdated
| @@ -20,6 +20,46 @@ class BalanceClassSampler(Sampler): | |||
| labels: list of class label for each elem in the dataset | |||
| mode: Strategy to balance classes. | |||
| Must be one of [downsampling, upsampling] | |||
|
|
|||
There was a problem hiding this comment.
[pep8] reported by reviewdog 🐶
W293 blank line contains whitespace
catalyst/data/sampler.py
Outdated
| "train": DataLoader(train_data, sampler=train_sampler, batch_size=32), | ||
| "valid": DataLoader(valid_data, batch_size=32), | ||
| } | ||
|
|
There was a problem hiding this comment.
[pep8] reported by reviewdog 🐶
W293 blank line contains whitespace
catalyst/data/sampler.py
Outdated
| labels: list of classes labeles for each elem in the dataset | ||
| num_classes: number of classes in a batch, should be > 1 | ||
| num_samples: number of instances of each class in a batch, should be > 1 | ||
| num_batches: number of batches in epoch |
There was a problem hiding this comment.
[pep8] reported by reviewdog 🐶
W291 trailing whitespace
catalyst/data/sampler.py
Outdated
|
|
||
| .. _In Defense of the Triplet Loss for Person Re-Identification: | ||
| https://arxiv.org/abs/1703.07737 | ||
|
|
There was a problem hiding this comment.
[pep8] reported by reviewdog 🐶
W293 blank line contains whitespace
| @@ -35,6 +43,44 @@ def generate_valid_labels(num: int) -> TLabelsPK: | |||
| return labels_pk | |||
|
|
|||
|
|
|||
| def test_balance_class_sampler(): | |||
There was a problem hiding this comment.
[pep8] reported by reviewdog 🐶
D103 Missing docstring in public function
| ), f"Each class shoud contain {mode} instances" | ||
|
|
||
|
|
||
| def test_batch_balance_class_sampler(): |
There was a problem hiding this comment.
[pep8] reported by reviewdog 🐶
D103 Missing docstring in public function
tests/catalyst/data/test_sampler.py
Outdated
| @@ -35,6 +43,46 @@ def generate_valid_labels(num: int) -> TLabelsPK: | |||
| return labels_pk | |||
|
|
|||
|
|
|||
| def test_balance_class_sampler(): | |||
| """BalanceClassSampler test.""" | |||
There was a problem hiding this comment.
[pep8] reported by reviewdog 🐶
D403 First word of the first line should be properly capitalized
tests/catalyst/data/test_sampler.py
Outdated
|
|
||
|
|
||
| def test_batch_balance_class_sampler(): | ||
| """BatchBalanceClassSampler test.""" |
There was a problem hiding this comment.
[pep8] reported by reviewdog 🐶
D403 First word of the first line should be properly capitalized
Before submitting (checklist)
catalyst-make-codestyle && catalyst-check-codestyle(pip install -U catalyst-codestyle).make check-docs?pytest .?latestandminimalrequirements?Description
Related Issue
Type of Change
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
FAQ
Please review the FAQ before submitting an issue: