Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add albumentations to registry #1238

Merged
merged 14 commits into from Jun 24, 2021

Conversation

y-ksenia
Copy link
Contributor

Before submitting (checklist)

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contribution guide?
  • Did you check the code style? catalyst-make-codestyle && catalyst-check-codestyle (pip install -U catalyst-codestyle).
  • Did you make sure to update the docs? We use Google format for all the methods and classes.
  • Did you check the docs with make check-docs?
  • Did you write any new necessary tests?
  • Did you check that your code passes the unit tests pytest . ?
  • Did you add your new functionality to the docs?
  • Did you update the CHANGELOG?
  • Did you run colab minimal CI/CD with latest and minimal requirements?

Description

Added integration with albumentations.

Related Issue

Type of Change

  • Examples / docs / tutorials / contributors update
  • Bug fix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves an existing feature)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

FAQ

Please review the FAQ before submitting an issue:

bagxi
bagxi previously approved these changes Jun 16, 2021
@mergify mergify bot dismissed bagxi’s stale review June 17, 2021 04:24

Pull request has been modified.

Scitator
Scitator previously approved these changes Jun 22, 2021
@@ -0,0 +1 @@
albumentations
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we have a minimum required version?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ops... forgot after varying versions


r.add_from_module(m, prefix=["A.", "albu.", "albumentations."])

from albumentations import pytorch as p
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for example, starting which version do we have PyTorch integrations under Albumentations?
and is it possible to wrap

from albumentations import pytorch as p
r.add_from_module(p, prefix=["A.", "albu.", "albumentations."])

with try-except? for the API change case? if there would be no pytorch integration?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I add a version of albumentations that supports pytorch integration, do I still need to wrap it via try-except?

Copy link
Member

@Scitator Scitator Jun 24, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what if... the will break the API in future releases? 🤔

@@ -1,5 +1,5 @@
imageio>=2.5.0
opencv-python-headless>=3.4.5.20
opencv-python-headless>=4.1.1.26
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why? 🤔

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

because of requirements of albumentations >= 0.5.1 (version of which I forgot to set)

bagxi
bagxi previously approved these changes Jun 23, 2021
@mergify mergify bot dismissed stale reviews from bagxi and Scitator June 24, 2021 10:09

Pull request has been modified.

@Scitator Scitator merged commit bc7ae8b into catalyst-team:master Jun 24, 2021
@y-ksenia y-ksenia deleted the registry_albumentations branch July 29, 2021 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants