Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests update (moved to tests folder) #1208

Merged
merged 18 commits into from May 10, 2021
Merged

Tests update (moved to tests folder) #1208

merged 18 commits into from May 10, 2021

Conversation

Scitator
Copy link
Member

Before submitting (checklist)

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contribution guide?
  • Did you check the code style? catalyst-make-codestyle && catalyst-check-codestyle (pip install -U catalyst-codestyle).
  • Did you make sure to update the docs? We use Google format for all the methods and classes.
  • Did you check the docs with make check-docs?
  • Did you write any new necessary tests?
  • Did you check that your code passes the unit tests pytest . ?
  • Did you add your new functionality to the docs?
  • Did you update the CHANGELOG?
  • Did you run colab minimal CI/CD with latest and minimal requirements?

Description

Related Issue

Type of Change

  • Examples / docs / tutorials / contributors update
  • Bug fix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves an existing feature)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

FAQ

Please review the FAQ before submitting an issue:

@pep8speaks
Copy link

pep8speaks commented May 10, 2021 •
edited

Hello @Scitator! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2021-05-10 08:52:57 UTC

@Scitator Scitator changed the title Demo update Tests update (moved to tests folder) May 10, 2021
github-actions[bot]
github-actions bot reviewed May 10, 2021
View reviewed changes
tests/__init__.py Outdated
@@ -0,0 +1 @@
# Needed to collect coverage data
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[pep8] reported by reviewdog 🐶
W292 no newline at end of file

tests/__init__.py Outdated
@@ -0,0 +1 @@
# Needed to collect coverage data
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[pep8] reported by reviewdog 🐶
W292 no newline at end of file

tests/__init__.py Outdated
@@ -0,0 +1 @@
# Needed to collect coverage data
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[pep8] reported by reviewdog 🐶
W292 no newline at end of file

tests/catalyst/__init__.py Outdated
@@ -0,0 +1 @@
# Needed to collect coverage data
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[pep8] reported by reviewdog 🐶
W292 no newline at end of file

tests/catalyst/__init__.py Outdated
@@ -0,0 +1 @@
# Needed to collect coverage data
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[pep8] reported by reviewdog 🐶
W292 no newline at end of file

tests/catalyst/__init__.py Outdated
@@ -0,0 +1 @@
# Needed to collect coverage data
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[pep8] reported by reviewdog 🐶
W292 no newline at end of file

@Scitator Scitator merged commit 3979394 into master May 10, 2021
@mergify mergify bot deleted the demo-update branch May 10, 2021 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions left review comments

@bagxi bagxi Awaiting requested review from bagxi bagxi is a code owner

@ditwoo ditwoo Awaiting requested review from ditwoo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Scitator @pep8speaks