New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add NeptuneLogger [WIP] #1196
add NeptuneLogger [WIP] #1196
Conversation
…test drives by new people
Hello @kamil-kaczmarek! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2021-04-30 14:16:15 UTC |
Opened draft pull request. Note that we are still polishing it :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the overall implementation looks great!
could you please resolve the codestyle issues?
pip install -r requirements/requireemnts-dev.txt
catalyst-make-codestyle
catalyst-check-codestyle
|
Co-authored-by: Sergey Kolesnikov <scitator@gmail.com>
quick note: I'll mention the problem with finetune2 test to our devs. |
hey @Scitator, @HubertJaworski from our team will finalize the implemenation today! |
Hi @Scitator This PR is ready from our end now. I'm unable to remove [WIP] tag - can you help? I managed to fix the test - the loggers were not being added. I took liberty to add neptune's requirements to pip installations in your CICD and add a check for Neptune's integration in I also added some bash functions to improve copy-paste code of pip cleanup & |
@Scitator we were missing changes to CHANGELOG and loggers docs, I've updated that. There are two tests failing, but it seems that it's due to some timeout. @kamil-kaczmarek created the PR and he is off today (🏝🌴🏝) so I cannot update the checklist :) |
Co-authored-by: Sergey Kolesnikov <scitator@gmail.com>
Before submitting (checklist)
catalyst-make-codestyle && catalyst-check-codestyle
(pip install -U catalyst-codestyle
).make check-docs
?pytest .
?latest
andminimal
requirements?Description
NeptuneLogger
log_artifact
to the logger, so that user can log arbitrary files (not limited to images anymore)Related Issue
Type of Change
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
FAQ
Please review the FAQ before submitting an issue: