reid 2.0

[julia-shenshina]

Before submitting (checklist)

• Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
• Did you read the contribution guide?
• Did you check the code style? catalyst-make-codestyle && catalyst-check-codestyle (pip install -U catalyst-codestyle).
• Did you make sure to update the docs? We use Google format for all the methods and classes.
• Did you check the docs with make check-docs?
• Did you write any new necessary tests?
• Did you check that your code passes the unit tests pytest . ?
• Did you add your new functionality to the docs?
• Did you update the CHANGELOG?
• Did you run colab minimal CI/CD with latest and minimal requirements?

Description

Related Issue

Type of Change

• Examples / docs / tutorials / contributors update
• Bug fix (non-breaking change which fixes an issue)
• Improvement (non-breaking change which improves an existing feature)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

PS

• I know, that I could join slack for pull request discussion.

[pep8speaks]

Hello @julia-shenshina! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

• In the file catalyst/metrics/functional/tests/test_cmc_metric.py:

Line 175:81: E231 missing whitespace after ','
Line 176:67: E231 missing whitespace after ','
Line 186:98: E231 missing whitespace after ','
Line 192:69: E231 missing whitespace after ','
Line 193:58: E231 missing whitespace after ','

Comment last updated at 2021-04-11 10:27:48 UTC

[Scitator]

could you please also add it to the catalyst/metrics/functional/__init__.py and the docs?