Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in SchedulerCallback and write all LRs to metrics #1017

Merged
merged 8 commits into from Dec 4, 2020

Conversation

and-kul
Copy link
Contributor

@and-kul and-kul commented Dec 2, 2020

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contribution guide?
  • Did you check the code style? catalyst-make-codestyle && catalyst-check-codestyle (pip install -U catalyst-codestyle).
  • Did you make sure to update the docs? We use Google format for all the methods and classes.
  • Did you check the docs with make check-docs?
  • Did you write any new necessary tests?
  • Did you check that your code passes the unit tests pytest . ?
  • Did you add your new functionality to the docs?
  • Did you update the CHANGELOG?

Description

  1. Fix bug in SchedulerCallback, described in Warning in torch.lr_scheduler #989
  2. If you have many param_groups in optimizer then log LRs and momentums for each of them

Related Issue

#989

Type of Change

  • Examples / docs / tutorials / contributors update
  • Bug fix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves an existing feature)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

@pep8speaks
Copy link

pep8speaks commented Dec 2, 2020

Hello @and-kul! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2020-12-04 14:55:55 UTC

@Scitator
Copy link
Member

Scitator commented Dec 3, 2020

could you please check fix the codestyle?
catalyst-make-codestyle && catalyst-check-codestyle (pip install -U catalyst-codestyle).

it would be also cool, if you could drop a minimal example in colab with "how now it working" example :)

@and-kul
Copy link
Contributor Author

and-kul commented Dec 3, 2020

Codestyle is fixed

catalyst/utils/torch.py Show resolved Hide resolved
catalyst/callbacks/scheduler.py Outdated Show resolved Hide resolved
catalyst/callbacks/scheduler.py Outdated Show resolved Hide resolved
@Scitator Scitator merged commit 92ec6f9 into catalyst-team:master Dec 4, 2020
@and-kul and-kul deleted the scheduler_callback branch December 4, 2020 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants