New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge AMPOptimizerCallback and OptimizerCallback #1007
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Scitator
reviewed
Nov 23, 2020
catalyst/runners/runner.py
Outdated
@@ -30,6 +31,33 @@ | |||
from catalyst.utils.tracing import save_traced_model, trace_model | |||
|
|||
|
|||
def resolve_bool_fp16(fp16: Union[Dict, bool]): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could we make it _resolve_bool_fp16
? or move to catalyst/runner/functional.py
? I just want to keep runner.py
clean and clear :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
Co-authored-by: Sergey Kolesnikov <scitator@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting
catalyst-make-codestyle && catalyst-check-codestyle
(pip install -U catalyst-codestyle
).make check-docs
?pytest .
?Description
AMPOptimizerCallback
and move its functionality intoOptimizerCallback
fp16=True
inrunner.train
:OptimizerCallback
now have 2 new args:use_amp
anduse_apex
. They can be set manually or inferred fromrunner.experiment.distributed_params
decouple_weight_decay
by default is nowFalse
AdamW
optimizer in PyTorch itself, which implements decoupling logic)Type of Change
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
PS