New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/edit pull request template #955
Feature/edit pull request template #955
Conversation
Hello @zkid18! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:
|
.github/PULL_REQUEST_TEMPLATE.md
Outdated
- [ ] Did you add your new functionality to the docs? | ||
- [ ] Did you update the [CHANGELOG](https://github.com/catalyst-team/catalyst/CHANGELOG.md)? | ||
- [ ] Did you update the [CHANGELOG](https://github.com/catalyst-team/catalyst/blob/master/CHANGELOG.md)? | ||
- [x] **You can use 'Login as guest' to see Teamcity build logs.** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
btw, could you also remove this line, as far as it's deprecated already?)
- [x] **You can use 'Login as guest' to see Teamcity build logs.** |
Before submitting
catalyst-make-codestyle && catalyst-check-codestyle
(pip install -U catalyst-codestyle
).make check-docs
?Description
Related Issue
Type of Change
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.