-
-
Notifications
You must be signed in to change notification settings - Fork 393
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add albumentations to registry #1238
Add albumentations to registry #1238
Conversation
2bec557
to
e2ab6cb
Compare
18ac983
to
dd19f96
Compare
4c501fd
to
11c9a9b
Compare
requirements/requirements-albu.txt
Outdated
@@ -0,0 +1 @@ | |||
albumentations |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we have a minimum required version?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ops... forgot after varying versions
|
||
r.add_from_module(m, prefix=["A.", "albu.", "albumentations."]) | ||
|
||
from albumentations import pytorch as p |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for example, starting which version do we have PyTorch integrations under Albumentations?
and is it possible to wrap
from albumentations import pytorch as p
r.add_from_module(p, prefix=["A.", "albu.", "albumentations."])
with try-except? for the API change case? if there would be no pytorch
integration?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I add a version of albumentations that supports pytorch integration, do I still need to wrap it via try-except?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what if... the will break the API in future releases? 🤔
@@ -1,5 +1,5 @@ | |||
imageio>=2.5.0 | |||
opencv-python-headless>=3.4.5.20 | |||
opencv-python-headless>=4.1.1.26 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why? 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
because of requirements of albumentations >= 0.5.1 (version of which I forgot to set)
Pull request has been modified.
a953998
to
2ed8be4
Compare
2ed8be4
to
98d5115
Compare
Before submitting (checklist)
catalyst-make-codestyle && catalyst-check-codestyle
(pip install -U catalyst-codestyle
).make check-docs
?pytest .
?latest
andminimal
requirements?Description
Added integration with albumentations.
Related Issue
Type of Change
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
FAQ
Please review the FAQ before submitting an issue: