Fix return nodes from case statements (#350)

lib/solargraph/parser/rubyvm/node_methods.rb

@@ -197,7 +197,7 @@ def get_return_nodes node
                 result.push node
                 result.concat get_return_nodes_only(node.children[1])
               elsif node.type == :CASE
-                node.children.each do |cc|
+                node.children[1..-1].each do |cc|
                   result.concat reduce_to_value_nodes(cc.children[1..-1])
                 end
               else

lib/solargraph/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Solargraph
-  VERSION = '0.39.13'
+  VERSION = '0.39.14'
 end

spec/parser/node_methods_spec.rb

@@ -61,6 +61,44 @@
     expect(rets.length).to eq(2)
   end
 
+  it 'handles return nodes from case statements' do
+    node = Solargraph::Parser.parse(%(
+      case x
+      when 100
+        true
+      end
+    ))
+    returns = Solargraph::Parser::NodeMethods.returns_from(node)
+    # Include an implicit `nil` for missing else
+    expect(returns.length).to eq(2)
+  end
+
+  it 'handles return nodes from case statements with else' do
+    node = Solargraph::Parser.parse(%(
+      case x
+      when 100
+        true
+      else
+        false
+      end
+    ))
+    returns = Solargraph::Parser::NodeMethods.returns_from(node)
+    expect(returns.length).to eq(2)
+  end
+
+  it 'handles return nodes from case statements with boolean conditions' do
+    node = Solargraph::Parser.parse(%(
+      case true
+      when x
+        true
+      else
+        false
+      end
+    ))
+    returns = Solargraph::Parser::NodeMethods.returns_from(node)
+    expect(returns.length).to eq(2)
+  end
+
   it "handles return nodes in reduceable (begin) nodes" do
     # @todo Temporarily disabled. Result is 3 nodes instead of 2.
     # node = Solargraph::Parser.parse(%(