Add nullable reference type annotations to DynamicProxy's public API #668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stakx
commented
Sep 14, 2023
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
|
|
||
| namespace System.Diagnostics.CodeAnalysis |
There was a problem hiding this comment.
Is there a better directory to put this polyfill attribute file under than the root src/Castle.Core/? (I put it there because it could in theory be used across the whole library, not just for DynamicProxy.)
There was a problem hiding this comment.
We used to stick polyfills for .NET Framework while working with the early .NET Core versions into a Compatibility directory. Or you could literally call it Polyfills if you want. Probably best to keep out of the root like you suggested.
stakx
changed the title
stakx
force-pushed
the
enhancement/nullable-reference-type-annotations
branch
from
3e5cfd5
to
781960a
Compare
stakx
commented
Sep 14, 2023
stakx
commented
Sep 15, 2023
stakx
force-pushed
the
enhancement/nullable-reference-type-annotations
branch
from
781960a
to
a58f704
Compare
stakx
force-pushed
the
enhancement/nullable-reference-type-annotations
branch
from
a58f704
to
30bafc9
Compare
jonorossi
approved these changes
Oct 25, 2023
| { | ||
| bool IEqualityComparer<object>.Equals(object x, object y) | ||
| new public bool Equals(object? x, object? y) |
There was a problem hiding this comment.
Does this need the new keyword?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.