Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize & document InterfaceMembersOnClassCollector #667

Merged
merged 3 commits into from
Sep 10, 2023
Merged

Optimize & document InterfaceMembersOnClassCollector #667

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a28b72e
Inline `IsVirtuallyImplementedInterfaceMethod`
stakx Sep 10, 2023
634f44e
Remove redundant call to `GetMethodOnTarget`
stakx Sep 10, 2023
a0f7a44
Add explanation for the `onlyProxyVirtual` flag
stakx Sep 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
37 changes: 27 additions & 10 deletions src/Castle.Core/DynamicProxy/Contributors/InterfaceMembersOnClassCollector.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,12 +32,35 @@ public InterfaceMembersOnClassCollector(Type type, bool onlyProxyVirtual, Interf

protected override MetaMethod GetMethodToGenerate(MethodInfo method, IProxyGenerationHook hook, bool isStandalone)
{
if (onlyProxyVirtual && IsVirtuallyImplementedInterfaceMethod(method))
var methodOnTarget = GetMethodOnTarget(method);

if (onlyProxyVirtual)
{
return null;
}
// The (somewhat confusingly named) `onlyProxyVirtual` flag may need some explaining.
//
// This collector type is used in two distinct scenarios:
//
// 1. When generating a class proxy for some class `T` which implements interface `I`,
// and `I` is again specified as an additional interface to add to the proxy type.
// In this case, this collector gets invoked for `I` and `onlyProxyVirtual == true`,
// and below logic prevents `I` methods from being implemented a second time when
// the main "target" contributor already took care of them (which happens when they
// are overridable, or more specifically, when they are implicitly implemented and
// marked as `virtual`).
//
// 2. When generating an interface proxy with target for some interface `I` and target
// type `T`. In this case, `onlyProxyVirtual == false`, which forces members of `I`
// to get implemented. Unlike in (1), the target of such proxies will be separate
// objects, so it doesn't matter if & how they implement members of `I` or not;
// those `I` members still need to be implemented on the proxy type regardless.

var methodOnTarget = GetMethodOnTarget(method);
var isVirtuallyImplementedInterfaceMethod = methodOnTarget != null && methodOnTarget.IsFinal == false;

if (isVirtuallyImplementedInterfaceMethod)
{
return null;
}
}

var proxyable = AcceptMethod(method, onlyProxyVirtual, hook);
return new MetaMethod(method, methodOnTarget, isStandalone, proxyable, methodOnTarget.IsPrivate == false);
Expand All @@ -53,11 +76,5 @@ private MethodInfo GetMethodOnTarget(MethodInfo method)

return map.TargetMethods[index];
}

private bool IsVirtuallyImplementedInterfaceMethod(MethodInfo method)
{
var info = GetMethodOnTarget(method);
return info != null && info.IsFinal == false;
}
}
}