Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ArgumentException: "Could not find method overriding method" with overridden class method having generic by-ref parameter #657

Merged
merged 3 commits into from Aug 28, 2023

Conversation

stakx
Copy link
Member

@stakx stakx commented Aug 23, 2023

Fixes #655.

@stakx
Copy link
Member Author

stakx commented Aug 23, 2023

@castleproject/committers, I'll leave this open for review for a week or two, but since it seems like a pretty straightforward bug fix, I'll merge it after that.

@stakx stakx added this to the vNext milestone Aug 23, 2023
Copy link
Member

@jonorossi jonorossi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense.

I think the changelog should acknowledge yourself as the fixer rather than the bug reporter, or both since they provided some test code.

This triggers a `ArgumentException`: "Could not find method overriding
[...]. This is most likely a bug. Please report it."
@stakx stakx force-pushed the bug/method-invocation-target branch from c6c222c to 46fbe94 Compare August 28, 2023 09:44
@stakx stakx force-pushed the bug/method-invocation-target branch from 46fbe94 to d7d8f6d Compare August 28, 2023 09:55
@stakx stakx merged commit 2537a23 into castleproject:master Aug 28, 2023
4 checks passed
@stakx stakx deleted the bug/method-invocation-target branch August 28, 2023 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants