Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix generated assembly to be collectible #610

Closed
wants to merge 1 commit into from

Conversation

m08pvv
Copy link

@m08pvv m08pvv commented Mar 21, 2022

Fixed issue #473

Signed-off-by: vpetrov <vpetrov@systemorph.com>
@jonorossi
Copy link
Member

Sorry for the delay in reviewing this.

I expected the unit tests to have failed with the Restrictions on collectible assemblies saying these assemblies are "transient (that is, it cannot be saved)". I assume that the unit tests are following the previous branch which uses RunAndSave and so this has no unit tests.

With the number of restrictions on collectable dynamic assemblies I think this will probably need to be an opt-in selection. I can't quite understand the details but there sounds like a big gotchas where non-collectable assemblies can't reference collectable assemblies.

Could you please share some details about the testing you've done. Thanks.

@jonorossi
Copy link
Member

Closing as stale.

@jonorossi jonorossi closed this May 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants