Add support for System.UIntPtr
#547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stakx
commented
Jan 3, 2021
| @@ -72,7 +72,7 @@ private void EmitByRef(ILGenerator gen) | |||
|
|
|||
| private bool IsPrimitiveOrClass(Type type) | |||
| { | |||
| if ((type.IsPrimitive && type != typeof(IntPtr))) | |||
| if (type.IsPrimitive && type != typeof(IntPtr) && type != typeof(UIntPtr)) | |||
There was a problem hiding this comment.
Maybe worth noting that this double check for both IntPtr and UIntPtr is already present in other locations; it was only missing here.
DynamicProxy will now produce the same IL sequences for `UIntPtr` as it
already does for `IntPtr`:
* For default return values:
ldloca.s <n>
initobj [mscorlib]System.UIntPtr
ldloc.<n>
ret
* For out parameters:
ldarg.<n>
initobj [mscorlib]System.UIntPtr
(For comparison, the C# compiler wouldn't emit `initobj`, but instead
`ldc.i4.0` followed by `conv.i`.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #546.
(The one longish commit message isn't strictly necessary for understanding this bugfix... in fact, it's quite unrelated. I was originally going to optimize the emitted IL a little, but decided to defer that to a later time. I'm leaving the commit message for later reference.)