Remove serialization support in DynamicProxy

CHANGELOG.md

@@ -9,6 +9,10 @@ Deprecations:
  - Removed support for the .NET Framework < 4.5 and .NET Standard 1.x. (@stakx, #495, #496)
  - Removed support for Code Access Security (CAS). (@stakx, #502)
  - Removed support for Remoting. This library no longer defines any types deriving from `MarshalByRefObject`, and `ProxyUtil.IsProxy` (which used to recognize remoting/"transparent" proxies) now tests only for DynamicProxy proxies. (@stakx, #507)
+ - Removed support for serialization in DynamicProxy. To be more specific, this means that:
+    - Previously saved dynamic assemblies can no longer be loaded into a `ProxyGenerator`'s type cache (via `ModuleScope.LoadAssemblyIntoCache`).
+    - Generated proxies and invocations are no longer marked as `[Serializable]` nor do they automatically implement `ISerializable`.
+    - There is no longer any requirement to make your interceptors, interceptor selectors, proxy generation hooks, or mixins serializable. (@stakx, #512)
  - The following public members have been removed:
     - `Castle.Core.Internal.Lock` (class) along with all related types and methods
     - `Castle.Core.Internal.PermissionUtil.IsGranted` (method)

docs/dynamicproxy.md

@@ -15,7 +15,6 @@ If you're new to DynamicProxy you can read a [quick introduction](dynamicproxy-i
 * [Leaking this](dynamicproxy-leaking-this.md)
 * [Make proxy generation hooks purely functional](dynamicproxy-generation-hook-pure-function.md)
 * [Overriding Equals/GetHashCode on proxy generation hook](dynamicproxy-generation-hook-override-equals-gethashcode.md)
-* [Make your supporting classes serializable](dynamicproxy-serializable-types.md)
 * [Use proxy generation hooks and interceptor selectors for fine grained control](dynamicproxy-fine-grained-control.md)
 * [SRP applies to interceptors](dynamicproxy-srp-applies-to-interceptors.md)
 * [Behavior of by-reference parameters during interception](dynamicproxy-by-ref-parameters.md)

ref/Castle.Core-net45.cs

@@ -2639,7 +2639,6 @@ public class ModuleScope
         public string StrongNamedModuleName { get; }
         public string WeakNamedModuleDirectory { get; }
         public string WeakNamedModuleName { get; }
-        public void LoadAssemblyIntoCache(System.Reflection.Assembly assembly) { }
         public string SaveAssembly() { }
         public string SaveAssembly(bool strongNamed) { }
         public static byte[] GetKeyPair() { }
@@ -2650,7 +2649,7 @@ public class PersistentProxyBuilder : Castle.DynamicProxy.DefaultProxyBuilder
         public string SaveAssembly() { }
     }
     public class ProxyGenerationException : System.Exception { }
-    public class ProxyGenerationOptions : System.Runtime.Serialization.ISerializable
+    public class ProxyGenerationOptions
     {
         public static readonly Castle.DynamicProxy.ProxyGenerationOptions Default;
         public ProxyGenerationOptions() { }
@@ -2666,7 +2665,6 @@ public class ProxyGenerationOptions : System.Runtime.Serialization.ISerializable
         public void AddMixinInstance(object instance) { }
         public override bool Equals(object obj) { }
         public override int GetHashCode() { }
-        public void GetObjectData(System.Runtime.Serialization.SerializationInfo info, System.Runtime.Serialization.StreamingContext context) { }
         public void Initialize() { }
         public object[] MixinsAsArray() { }
     }
@@ -2794,30 +2792,5 @@ public static class TypeUtil
     {
         public static System.Type[] GetAllInterfaces(this System.Type type) { }
         public static System.Type GetTypeOrNull(object target) { }
-        public static System.Reflection.MemberInfo[] Sort(System.Reflection.MemberInfo[] members) { }
-    }
-}
-namespace Castle.DynamicProxy.Serialization
-{
-    [System.AttributeUsage(System.AttributeTargets.Assembly | System.AttributeTargets.All, AllowMultiple=false)]
-    [System.CLSCompliant(false)]
-    public class CacheMappingsAttribute : System.Attribute
-    {
-        public CacheMappingsAttribute(byte[] serializedCacheMappings) { }
-        public byte[] SerializedCacheMappings { get; }
-    }
-    public class ProxyObjectReference : System.Runtime.Serialization.IDeserializationCallback, System.Runtime.Serialization.IObjectReference, System.Runtime.Serialization.ISerializable
-    {
-        protected ProxyObjectReference(System.Runtime.Serialization.SerializationInfo info, System.Runtime.Serialization.StreamingContext context) { }
-        public static Castle.DynamicProxy.ModuleScope ModuleScope { get; }
-        public void GetObjectData(System.Runtime.Serialization.SerializationInfo info, System.Runtime.Serialization.StreamingContext context) { }
-        public object GetRealObject(System.Runtime.Serialization.StreamingContext context) { }
-        protected void InvokeCallback(object target) { }
-        public void OnDeserialization(object sender) { }
-        public object RecreateClassProxy() { }
-        public object RecreateInterfaceProxy(string generatorType) { }
-        protected virtual object RecreateProxy() { }
-        public static void ResetScope() { }
-        public static void SetScope(Castle.DynamicProxy.ModuleScope scope) { }
     }
 }

ref/Castle.Core-netstandard2.0.cs

@@ -2763,6 +2763,5 @@ public static class TypeUtil
     {
         public static System.Type[] GetAllInterfaces(this System.Type type) { }
         public static System.Type GetTypeOrNull(object target) { }
-        public static System.Reflection.MemberInfo[] Sort(System.Reflection.MemberInfo[] members) { }
     }
 }

ref/Castle.Core-netstandard2.1.cs

@@ -2763,6 +2763,5 @@ public static class TypeUtil
     {
         public static System.Type[] GetAllInterfaces(this System.Type type) { }
         public static System.Type GetTypeOrNull(object target) { }
-        public static System.Reflection.MemberInfo[] Sort(System.Reflection.MemberInfo[] members) { }
     }
 }

src/Castle.Core.Tests/DynamicProxy.Tests/Classes/ClassOverridingEqualsAndGetHashCode.cs

@@ -16,9 +16,6 @@ namespace Castle.DynamicProxy.Tests.Classes
 {
 	using System;
 
-#if FEATURE_SERIALIZATION
-	[Serializable]
-#endif
 	public class ClassOverridingEqualsAndGetHashCode
 	{
 		private Guid _id;

src/Castle.Core.Tests/DynamicProxy.Tests/Classes/ClassWithInterface.cs

@@ -16,9 +16,6 @@ namespace Castle.DynamicProxy.Tests.Classes
 {
 	using System;
 
-#if FEATURE_SERIALIZATION
-	[Serializable]
-#endif
 	public class ClassWithInterface : ISimpleInterface
 	{
 		public int Do()

src/Castle.Core.Tests/DynamicProxy.Tests/Classes/HasNonInheritableAttribute.cs

@@ -60,9 +60,6 @@ public virtual void Do2()
 		}
 	}
 
-#if FEATURE_SERIALIZATION
-	[Serializable]
-#endif
 	[AttributeUsage(AttributeTargets.All, Inherited = false)]
 	public class ComplexNonInheritableAttribute : Attribute
 	{

src/Castle.Core.Tests/DynamicProxy.Tests/Classes/InheritableAttribute.cs

@@ -16,9 +16,6 @@ namespace Castle.DynamicProxy.Tests.Classes
 {
 	using System;
 
-#if FEATURE_SERIALIZATION
-	[Serializable]
-#endif
 	[AttributeUsage(AttributeTargets.All, Inherited = true)]
 	public class InheritableAttribute : Attribute
 	{

src/Castle.Core.Tests/DynamicProxy.Tests/Classes/NonInheritableAttribute.cs

@@ -16,9 +16,6 @@ namespace Castle.DynamicProxy.Tests.Classes
 {
 	using System;
 
-#if FEATURE_SERIALIZATION
-	[Serializable]
-#endif
 	[AttributeUsage(AttributeTargets.All, Inherited = false)]
 	public class NonInheritableAttribute : Attribute
 	{

src/Castle.Core.Tests/DynamicProxy.Tests/Classes/NonInheritableWithArray2Attribute.cs

@@ -16,9 +16,6 @@ namespace Castle.DynamicProxy.Tests.Classes
 {
 	using System;
 
-#if FEATURE_SERIALIZATION
-	[Serializable]
-#endif
 	[AttributeUsage(AttributeTargets.All, Inherited = false)]
 	public class NonInheritableWithArray2Attribute : Attribute
 	{

src/Castle.Core.Tests/DynamicProxy.Tests/Classes/NonInheritableWithArrayAttribute.cs

@@ -16,9 +16,6 @@ namespace Castle.DynamicProxy.Tests.Classes
 {
 	using System;
 
-#if FEATURE_SERIALIZATION
-	[Serializable]
-#endif
 	[AttributeUsage(AttributeTargets.All, Inherited = false)]
 	public class NonInheritableWithArrayAttribute : Attribute
 	{

src/Castle.Core.Tests/DynamicProxy.Tests/Classes/SimpleClass.cs → src/Castle.Core.Tests/DynamicProxy.Tests/Classes/SerializableClass.cs

@@ -14,7 +14,10 @@
 
 namespace Castle.DynamicProxy.Tests.Classes
 {
-	public class SimpleClass
+	using System;
+
+	[Serializable]
+	public class SerializableClass
 	{
 	}
-}
+}

src/Castle.Core.Tests/DynamicProxy.Tests/Serialization/SerializableExplicitImpl.cs → src/Castle.Core.Tests/DynamicProxy.Tests/Classes/SerializableExplicitImpl.cs

@@ -12,9 +12,7 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-#if FEATURE_SERIALIZATION
-
-namespace Castle.DynamicProxy.Tests.Serialization
+namespace Castle.DynamicProxy.Tests.Classes
 {
 	using System;
 	using System.Runtime.Serialization;
@@ -27,5 +25,3 @@ void ISerializable.GetObjectData(SerializationInfo info, StreamingContext contex
 		}
 	}
 }
-
-#endif