Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix broken Linux CI build on Appveyor #496

Merged
merged 8 commits into from May 6, 2020
Merged

Fix broken Linux CI build on Appveyor #496

merged 8 commits into from May 6, 2020

Commits on May 6, 2020

  1. Remove net35 target framework 

    The new .NET CLI (`dotnet`) cannot build projects that target `net35`,
because it cannot locate the required reference assemblies.

Since we're planning to drop support for .NET Framework 3.5 anyway, it
is not worth finding a workaround for this problem--let's just remove
that target framework now.

References:

 * dotnet/msbuild#1333
    @stakx
    stakx committed May 6, 2020
    Copy the full SHA
    ff78eb4 View commit details
    Browse the repository at this point in the history

  2. Mention only currently supported targets in docs 

    We no longer mention .NET Framework 3.5 support in the docs, let's do
likewise for Silverlight.
    @stakx
    stakx committed May 6, 2020
    Copy the full SHA
    9e72dec View commit details
    Browse the repository at this point in the history

  3. Update ref/ contracts 

    There are additions to the public API for `netstandard1.x`, which is
due to some `#if`s that were previously too restrictive. (`ISet<T>` is
not just supported on .NET 4.x, but on anything newer than .NET 3.5.)
    @stakx
    stakx committed May 6, 2020
    Copy the full SHA
    2b606a9 View commit details
    Browse the repository at this point in the history

  4. Update the changelog

    @stakx
    stakx committed May 6, 2020
    Copy the full SHA
    737aaa1 View commit details
    Browse the repository at this point in the history

  5. Use official reference assemblies NuGet package 

    Now our build no longer relies on Mono to provide reference assemblies
for the .NET Framework, and we no longer need to know where they are
located.
    @stakx
    stakx committed May 6, 2020
    Copy the full SHA
    c5749e1 View commit details
    Browse the repository at this point in the history

  6. Simplify package restore and build using dotnet 

    `dotnet build` restores packages by default, so explicitly restoring
packages shouldn't be necessary.

Also, there's no more need to build individual projects; `dotnet` can
build whole solutions.
    @stakx
    stakx committed May 6, 2020
    Copy the full SHA
    e1eb726 View commit details
    Browse the repository at this point in the history

  7. Prefer to run mono via Docker 

    This lets us choose which version of Mono to use without having to
install it.

This is important because the version currently preinstalled on App-
Veyor has a regression that breaks our build, and installing another
Mono version on AppVeyor is both slow and error-prone.
    @stakx
    stakx committed May 6, 2020
    Copy the full SHA
    3051a36 View commit details
    Browse the repository at this point in the history

  8. Use VS 2019 tooling for Windows build

    @stakx
    stakx committed May 6, 2020
    Copy the full SHA
    6685222 View commit details
    Browse the repository at this point in the history