Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Match generic type parameters by position, not by name #465

Closed
wants to merge 6 commits into from
Closed

Match generic type parameters by position, not by name #465

wants to merge 6 commits into from

Commits on Aug 13, 2019

  1. Add test failing due to generic type param mismatch

    @stakx
    stakx committed Aug 13, 2019
    Configuration menu
    Copy the full SHA
    b8cddcf View commit details
    Browse the repository at this point in the history

  2. Match generic parameters by position, not name

    @stakx
    stakx committed Aug 13, 2019
    Configuration menu
    Copy the full SHA
    1e24b58 View commit details
    Browse the repository at this point in the history

  3. Make fix more efficient by avoiding LINQ query 

    It turns out that beside the name-to-parameter map `name2GenericType`,
we also have a position-to-parameter map available that we can use in-
stead of a costly LINQ query: `genericTypeParams`.
    @stakx
    stakx committed Aug 13, 2019
    Configuration menu
    Copy the full SHA
    9675d48 View commit details
    Browse the repository at this point in the history

  4. Untested & most likely unreachable code 

    ... but let's not turn into a debug-only assertion, because if it *is*
reachable against our assumptions we need to find out about it so that
we can add a test case.
    @stakx
    stakx committed Aug 13, 2019
    Configuration menu
    Copy the full SHA
    a47b010 View commit details
    Browse the repository at this point in the history

  5. Update the changelog

    @stakx
    stakx committed Aug 13, 2019
    Configuration menu
    Copy the full SHA
    2c2d649 View commit details
    Browse the repository at this point in the history

  6. Update public contract files (ref/)

    @stakx
    stakx committed Aug 13, 2019
    Configuration menu
    Copy the full SHA
    3acb4d5 View commit details
    Browse the repository at this point in the history