Internal cleanups #318
Merged
Internal cleanups #318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JakeWharton
commented
Apr 11, 2024
Comment on lines
-216
to
-218
| val job = scope.launch(unconfined, start = UNDISPATCHED) { | ||
| channel = collectIntoChannel(this) | ||
| } |
There was a problem hiding this comment.
Now that tests aren't using collectIntoChannel, we can inline it and remove this pointless double launch.
JakeWharton
commented
Apr 11, 2024
Comment on lines
-236
to
-245
| return object : Channel<T> by output { | ||
| override fun cancel(cause: CancellationException?) { | ||
| job.cancel() | ||
| output.close(cause) | ||
| } | ||
|
|
||
| override fun close(cause: Throwable?): Boolean { | ||
| job.cancel() | ||
| return output.close(cause) | ||
| } |
There was a problem hiding this comment.
This was wrapping to mix-in behavior only to be re-wrapped in ChannelTurbine. Meanwhile we pass in the job to ChannelTurbine, so just do all the work there.
jingibus
approved these changes
Apr 11, 2024
JakeWharton
force-pushed
the
jw.stuff.2024-04-10
branch
from
24916aa
to
942abaa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGELOG.md's "Unreleased" section has been updated, if applicable.