Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Gradle to v8.0.2 #3971

Merged
merged 4 commits into from
Mar 18, 2023
Merged

Update Gradle to v8.0.2 #3971

merged 4 commits into from
Mar 18, 2023

Conversation

3flex
Copy link
Contributor

@3flex 3flex commented Mar 16, 2023 •
edited

Closes #3879

@JakeWharton
Copy link
Member

Let's cherry pick in the Gradle 8 update commit and see?

@JakeWharton
Copy link
Member

Seems like it works. Just need equivalent fixes in some test fixtures.

@3flex 3flex changed the title Work around KT-55751 Update Gradle to v8.0.2 Mar 17, 2023
@3flex
Copy link
Contributor Author

3flex commented Mar 18, 2023 •
edited

Thwarted by flaky CI (a dependency couldn't download because of HTTP 504 error) - can you please rerun the failing job? I should have found all the issues by now hopefully.

@JakeWharton
Copy link
Member

JakeWharton commented Mar 18, 2023 •
edited

Did what I could from the app. Might be worth just doing an empty commit --amend to update the timestamp and force push to make sure they all rerun.

@JakeWharton JakeWharton merged commit a56da30 into cashapp:master Mar 18, 2023
@JakeWharton
Copy link
Member

Thanks!

@3flex 3flex deleted the KT-55751 branch March 18, 2023 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JakeWharton JakeWharton JakeWharton approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@3flex @JakeWharton